You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2019/02/02 20:43:00 UTC
[jira] [Commented] (SOLR-8033) useless if branch (commented out
log.debug in HdfsTransactionLog constructor)
[ https://issues.apache.org/jira/browse/SOLR-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759191#comment-16759191 ]
Kevin Risden commented on SOLR-8033:
------------------------------------
FWIW this is still like this on master. ~3 years later.
> useless if branch (commented out log.debug in HdfsTransactionLog constructor)
> -----------------------------------------------------------------------------
>
> Key: SOLR-8033
> URL: https://issues.apache.org/jira/browse/SOLR-8033
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0, 5.1
> Reporter: songwanging
> Priority: Minor
> Labels: newdev
>
> In method HdfsTransactionLog() of class HdfsTransactionLog (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)
> The if branch presented in the following code snippet performs no actions, we should add more code to handle this or directly delete this if branch.
> HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String> globalStrings, boolean openExisting) {
> ...
> try {
> if (debug) {
> //log.debug("New TransactionLog file=" + tlogFile + ", exists=" + tlogFile.exists() + ", size=" + tlogFile.length() + ", openExisting=" + openExisting);
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org