You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/02/22 18:57:19 UTC
Review Request 56943: "Use RedHat Satellite/Spacewalk" setting not
working correctly in Ambari 2.4.2.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56943/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-20119
https://issues.apache.org/jira/browse/AMBARI-20119
Repository: ambari
Description
-------
In Ambari 2.4.2.0, the "Use RedHat Satellite/Spacewalk" button does not work and persist.
I have outlined the procedure to test. in "Testing Procedure" field below. In addition to that, even if we go and manually edit the repository file, next time Ambari does a Install operation (can be triggered by "Stop All/Start All" sequence of operations ), it overwrites the file with original repo files and not leave it to Satellite managed.
The feature works as expected in Ambari 2.4.0.0.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 0b8cab8
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java 9ca6cf4
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 437cc42
Diff: https://reviews.apache.org/r/56943/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 56943: "Use RedHat Satellite/Spacewalk" setting not
working correctly in Ambari 2.4.2.0
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56943/#review166419
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 22, 2017, 1:57 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56943/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 1:57 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-20119
> https://issues.apache.org/jira/browse/AMBARI-20119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari 2.4.2.0, the "Use RedHat Satellite/Spacewalk" button does not work and persist.
> I have outlined the procedure to test. in "Testing Procedure" field below. In addition to that, even if we go and manually edit the repository file, next time Ambari does a Install operation (can be triggered by "Stop All/Start All" sequence of operations ), it overwrites the file with original repo files and not leave it to Satellite managed.
>
> The feature works as expected in Ambari 2.4.0.0.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 0b8cab8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java 9ca6cf4
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 437cc42
>
> Diff: https://reviews.apache.org/r/56943/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 56943: "Use RedHat Satellite/Spacewalk" setting not
working correctly in Ambari 2.4.2.0
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56943/#review166408
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 22, 2017, 6:57 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56943/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 6:57 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-20119
> https://issues.apache.org/jira/browse/AMBARI-20119
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Ambari 2.4.2.0, the "Use RedHat Satellite/Spacewalk" button does not work and persist.
> I have outlined the procedure to test. in "Testing Procedure" field below. In addition to that, even if we go and manually edit the repository file, next time Ambari does a Install operation (can be triggered by "Stop All/Start All" sequence of operations ), it overwrites the file with original repo files and not leave it to Satellite managed.
>
> The feature works as expected in Ambari 2.4.0.0.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 0b8cab8
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java 9ca6cf4
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 437cc42
>
> Diff: https://reviews.apache.org/r/56943/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>