[GitHub] [spark] nvander1 commented on a change in pull request #29138: [SPARK-32338] [SQL] Overload slice to accept Column for start and length

[GitBox <gi...@apache.org>]

nvander1 commented on a change in pull request #29138:
URL: https://github.com/apache/spark/pull/29138#discussion_r456834819



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -3406,6 +3406,21 @@ object functions {
     Slice(x.expr, Literal(start), Literal(length))

Review comment:
       Yes, I'm making the change now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org