You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/08 09:36:51 UTC
[GitHub] incubator-zeppelin pull request #976: ZEPPLIN-976 ] HotFix - Incorrect "Cred...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/976
ZEPPLIN-976 ] HotFix - Incorrect "Credentials" server does not restart.
### What is this PR for?
Incorrect "Credentials" server does not restart.
reproduce.
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
##### but, Zeppelin does not work.
It creates the wrong json file. 'conf / credentials.json' according to the null.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-976
### How should this be tested?
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
zeppelin does work!
### Reproduced Screenshots
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin hotfix/CredentialsJsonBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #976
----
commit 1e5cd727c499ea1b700c1d9df81dd7aa69fa4fc9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-08T09:12:39Z
Credentials Json serialize backend bug.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #976: ZEPPLIN-976 ] HotFix - zeppelin server does n...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/976
@cloverhearts thank you for hotfixing!
How do you think, is there a chance we could have a test that reproduces this issue under this PR or do you think it would be to hard add?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #976: ZEPPLIN-976 ] HotFix - Incorrect "Credentials...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/976
retry ci
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #976: ZEPPLIN-976 ] HotFix - Incorrect "Cred...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #976: ZEPPLIN-976 ] HotFix - Incorrect "Cred...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/976
ZEPPLIN-976 ] HotFix - Incorrect "Credentials" server does not restart.
### What is this PR for?
Incorrect "Credentials" server does not restart.
reproduce.
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
##### but, Zeppelin does not work.
It creates the wrong json file. 'conf / credentials.json' according to the null.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-976
### How should this be tested?
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
zeppelin does work!
### Reproduced Screenshots
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin hotfix/CredentialsJsonBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/976.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #976
----
commit 1e5cd727c499ea1b700c1d9df81dd7aa69fa4fc9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-08T09:12:39Z
Credentials Json serialize backend bug.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---