You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "danepitkin (via GitHub)" <gi...@apache.org> on 2023/05/10 19:32:34 UTC

[GitHub] [arrow] danepitkin commented on a diff in pull request #35530: GH-35264: [Python] Interchange protocol: test clean-up

danepitkin commented on code in PR #35530:
URL: https://github.com/apache/arrow/pull/35530#discussion_r1190318537


##########
python/pyarrow/tests/interchange/test_conversion.py:
##########
@@ -217,19 +170,28 @@ def test_roundtrip_pandas_string():
 
 
 @pytest.mark.pandas
-def test_roundtrip_pandas_boolean():
-    if Version(pd.__version__) < Version("1.5.0"):
-        pytest.skip("__dataframe__ added to pandas in 1.5.0")
+def test_pandas_roundtrip_categorical():
+    if Version(pd.__version__) < Version("2.0.2"):

Review Comment:
   Should the pandas version for skipping tests due to `Column.size() bug in pandas` match between tests `test_pandas_roundtrip_string` (v2.0.1) and `test_pandas_roundtrip_categorical` (v2.0.2)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org