You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/01 13:43:20 UTC
[GitHub] srowen commented on issue #23901: [MINOR]Remove unnecessary gets
when getting a value from map.
srowen commented on issue #23901: [MINOR]Remove unnecessary gets when getting a value from map.
URL: https://github.com/apache/spark/pull/23901#issuecomment-468668639
I agree with the general principle of not changing trivial stuff because of merge conflicts. My logic here is: Spark 3 is a good place as back ports from 3 to 2 are pretty rare; we want to be able to touch up the code at some point; generally OK with this from newer contributors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org