You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Velmurugan Periasamy <vp...@hortonworks.com> on 2020/02/06 12:34:09 UTC
Re: Review Request 72057: RANGER-2588: Integrate Apache maven
checkstyle plugin to Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72057/#review219516
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Jan. 29, 2020, 8:43 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72057/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2020, 8:43 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2588
> https://issues.apache.org/jira/browse/RANGER-2588
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Please note that the patch includes the support of checkstyle but most of the rules are disabled in file "dev-support/checkstyle.xml"
>
> I will enable them and add required fix later to avoid to many conflict/changes at this moment.
>
> Currently, After this patch file length 6000 lines rule will be applied during ranger build.
>
>
> Diffs
> -----
>
> dev-support/checkstyle-java-header.txt PRE-CREATION
> dev-support/checkstyle-suppressions.xml PRE-CREATION
> dev-support/checkstyle.xml PRE-CREATION
> pom.xml f4cc712ae
>
>
> Diff: https://reviews.apache.org/r/72057/diff/1/
>
>
> Testing
> -------
>
> tested patch with "mvn clean install" command.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>