[GitHub] vdiravka commented on a change in pull request #1365: DRILL-6575: Add store.hive.conf.properties option to allow set Hive properties at session level

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1365: DRILL-6575: Add store.hive.conf.properties option to allow set Hive properties at session level
URL: https://github.com/apache/drill/pull/1365#discussion_r200728179
 
 

 ##########
 File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java
 ##########
 @@ -123,29 +126,40 @@ public HiveStoragePluginConfig getHiveStoragePluginConfig() {
     return columns;
   }
 
+  @JsonProperty
+  public Map<String, String> getConfProperties() {
+    return confProperties;
+  }
+
   @JsonIgnore
   public HiveStoragePlugin getStoragePlugin() {
     return hiveStoragePlugin;
   }
 
-  protected HiveMetadataProvider getMetadataProvider() {
-    return metadataProvider;
+  @JsonIgnore
+  public HiveConf getHiveConf() {
+    return HiveUtilities.generateHiveConf(hiveStoragePlugin.getHiveConf(), confProperties);
   }
 
-  private List<LogicalInputSplit> getInputSplits() {
-    if (inputSplits == null) {
-      inputSplits = metadataProvider.getInputSplits(hiveReadEntry);
-    }
-
-    return inputSplits;
+  @JsonIgnore
+  public boolean isNativeReader() {
+    return false;
   }
 
+  // Return true if the current table is partitioned false otherwise
 
 Review comment:
   JavaDoc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services