You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/10/08 06:16:30 UTC
Review Request 71588: ATLAS-3443: Enhancements to support 'Labels' in
Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-3443
https://issues.apache.org/jira/browse/ATLAS-3443
Repository: atlas
Description
-------
As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
notifications is not sent out for add/update/delete label operations from Atlas.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
Diff: https://reviews.apache.org/r/71588/diff/1/
Testing
-------
* Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
* Unit Tests added in AtlasEntityStoreV2Test
* Validated using REST to add/update/delete labels
Thanks,
Sarath Subramanian
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Sarath Subramanian <sa...@apache.org>.
> On Oct. 8, 2019, 9:25 a.m., Ashutosh Mestry wrote:
> > Please add entity JSON that includes the new field.
added the sample entity response in JIRA.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218133
-----------------------------------------------------------
On Oct. 7, 2019, 11:16 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2019, 11:16 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/1/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218133
-----------------------------------------------------------
Please add entity JSON that includes the new field.
- Ashutosh Mestry
On Oct. 8, 2019, 6:16 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2019, 6:16 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/1/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218131
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 8, 2019, 6:16 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2019, 6:16 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/1/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218141
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 2232 (patched)
<https://reviews.apache.org/r/71588/#comment305715>
- consider moving validateLabels() to AtlasEntityGraphDiscoveryV2 - similar to validateCustomAttributes()
- further, AtlasEntityStoreV2.setLabels() should validate the labels locally - similar to validation of classifications in addClassifications() and updateClassifications()
- Madhan Neethiraj
On Oct. 8, 2019, 9:27 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2019, 9:27 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/2/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1458/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218147
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 1083 (patched)
<https://reviews.apache.org/r/71588/#comment305721>
Consider moving 'if' at #1083 to getLables(String) method:
public static Set<String> getLabels(AtlasElement element) {
return getLables(element.getProperty(LABELS_PROPERTY_KEY, String.class);
}
private static Set<String> getLables(String labels) {
Set<String> ret = null;
if (StringUtils.isNotEmpty(labels)) {
for (String label : labels.split("\" + LABEL_NAME_DELIMITER)) {
if (StringUtils.isNotEmpty(label)) {
ret.add(label);
}
}
}
return ret;
}
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 1090 (patched)
<https://reviews.apache.org/r/71588/#comment305722>
- getLabels() => parseLabelsString()
- consider moving this 'private' method after all public and protected methods
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 335 (patched)
<https://reviews.apache.org/r/71588/#comment305720>
when label is null or empty, LABELS_PROPERTY_KEY property should be removed from the vertext - instead of skipping update. Please review.
- Madhan Neethiraj
On Oct. 8, 2019, 9:50 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2019, 9:50 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5547c398a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/3/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1459/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218148
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 9, 2019, 4:58 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2019, 4:58 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5547c398a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/4/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1459/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/
-----------------------------------------------------------
(Updated Oct. 8, 2019, 9:58 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-3443
https://issues.apache.org/jira/browse/ATLAS-3443
Repository: atlas
Description
-------
As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
notifications is not sent out for add/update/delete label operations from Atlas.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5547c398a
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
Diff: https://reviews.apache.org/r/71588/diff/4/
Changes: https://reviews.apache.org/r/71588/diff/3-4/
Testing
-------
* Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1459/console
* Unit Tests added in AtlasEntityStoreV2Test
* Validated using REST to add/update/delete labels
Thanks,
Sarath Subramanian
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/
-----------------------------------------------------------
(Updated Oct. 8, 2019, 2:50 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments
Bugs: ATLAS-3443
https://issues.apache.org/jira/browse/ATLAS-3443
Repository: atlas
Description
-------
As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
notifications is not sent out for add/update/delete label operations from Atlas.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java 5547c398a
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
Diff: https://reviews.apache.org/r/71588/diff/3/
Changes: https://reviews.apache.org/r/71588/diff/2-3/
Testing
-------
* Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1458/console
* Unit Tests added in AtlasEntityStoreV2Test
* Validated using REST to add/update/delete labels
Thanks,
Sarath Subramanian
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/
-----------------------------------------------------------
(Updated Oct. 8, 2019, 2:27 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
adressed review comments from Ashutosh.
Bugs: ATLAS-3443
https://issues.apache.org/jira/browse/ATLAS-3443
Repository: atlas
Description
-------
As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
notifications is not sent out for add/update/delete label operations from Atlas.
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 3aef6cd7f
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
Diff: https://reviews.apache.org/r/71588/diff/2/
Changes: https://reviews.apache.org/r/71588/diff/1-2/
Testing
-------
* Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1458/console
* Unit Tests added in AtlasEntityStoreV2Test
* Validated using REST to add/update/delete labels
Thanks,
Sarath Subramanian
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Sarath Subramanian <sa...@apache.org>.
> On Oct. 8, 2019, 9:24 a.m., Ashutosh Mestry wrote:
> > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
> > Line 993 (original)
> > <https://reviews.apache.org/r/71588/diff/1/?file=2168643#file2168643line1010>
> >
> > What is the reason for removing these?
overwrote the previous tests. Added back.
> On Oct. 8, 2019, 9:24 a.m., Ashutosh Mestry wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
> > Lines 855 (patched)
> > <https://reviews.apache.org/r/71588/diff/1/?file=2168644#file2168644line855>
> >
> > Consider moving this validation in lower layer. Perhaps EntityGraphMapper. May make sense to have it in AtlasGraphUtilsV2, that way it will be available for re-use.
moved validateLabels() to entityGraphMapper which can be accessed in retriever as well.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218132
-----------------------------------------------------------
On Oct. 7, 2019, 11:16 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2019, 11:16 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/1/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 71588: ATLAS-3443: Enhancements to support
'Labels' in Atlas
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71588/#review218132
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
Line 993 (original)
<https://reviews.apache.org/r/71588/#comment305710>
What is the reason for removing these?
webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Lines 855 (patched)
<https://reviews.apache.org/r/71588/#comment305711>
Consider moving this validation in lower layer. Perhaps EntityGraphMapper. May make sense to have it in AtlasGraphUtilsV2, that way it will be available for re-use.
- Ashutosh Mestry
On Oct. 8, 2019, 6:16 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71588/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2019, 6:16 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-3443
> https://issues.apache.org/jira/browse/ATLAS-3443
>
>
> Repository: atlas
>
>
> Description
> -------
>
> As a data steward, I would like to able to create Labels (user defined tags) in Atlas.
>
> User-defined labels (tags) can be created on an ad hoc basis and are not centrally managed for content and consistency, it is used for more crowdsourcing use cases.
>
>
>
> notifications is not sent out for add/update/delete label operations from Atlas.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java 357affd4c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java f9d5fe4e7
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 98123563f
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af01896a3
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 30c73753a
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 3dad3882e
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 01b8d196b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java 06335c064
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 4130014c4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9d9f6ef2d
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java b1506f8ec
> webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java e5b9563d6
>
>
> Diff: https://reviews.apache.org/r/71588/diff/1/
>
>
> Testing
> -------
>
> * Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1456/console
>
> * Unit Tests added in AtlasEntityStoreV2Test
>
> * Validated using REST to add/update/delete labels
>
>
> Thanks,
>
> Sarath Subramanian
>
>