[GitHub] [netbeans] dbalek commented on a diff in pull request #4448: #4447 - Fix missing code folding blocks in java editor for conditions, loops and try/catch

[GitBox <gi...@apache.org>]

dbalek commented on code in PR #4448:
URL: https://github.com/apache/netbeans/pull/4448#discussion_r1019251585


##########
java/java.editor.lib/src/org/netbeans/editor/ext/java/JavaFoldManager.java:
##########
@@ -43,6 +43,8 @@ public abstract class JavaFoldManager implements FoldManager {
     public static final FoldType JAVADOC_FOLD_TYPE = JavaElementFoldManager.JAVADOC_FOLD_TYPE;
 
     public static final FoldType CODE_BLOCK_FOLD_TYPE = JavaElementFoldManager.CODE_BLOCK_FOLD_TYPE;

Review Comment:
   Not sure what is better -  to preserve the backward semantic compatibility and potentially cause a confusion from non intuitive names or otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists