You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Yan Zhao <ho...@apache.org> on 2022/07/29 13:31:37 UTC
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
@Enrico
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by steven lu <lu...@gmail.com>.
I re-read the code again, look good to me
At the same time, please Enrico review the code, thank you
Yan Zhao <ho...@apache.org> 于2022年8月2日周二 13:30写道：
> Could you describe detail.
>
> On 2022/08/01 17:00:47 steven lu wrote:
> > I feel that the code is not the same as the discussion:
> > https://github.com/apache/bookkeeper/pull/3359
>
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by Yan Zhao <ho...@apache.org>.
Could you describe detail.
On 2022/08/01 17:00:47 steven lu wrote:
> I feel that the code is not the same as the discussion:
> https://github.com/apache/bookkeeper/pull/3359
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by steven lu <lu...@gmail.com>.
I feel that the code is not the same as the discussion:
https://github.com/apache/bookkeeper/pull/3359
Enrico Olivelli <eo...@gmail.com> 于2022年7月31日周日 01:55写道：
> Il Ven 29 Lug 2022, 19:24 Yan Zhao <ho...@apache.org> ha scritto:
>
> > You means we define api in EnsemblePlacementPolicy, and use SPI to load
> > special implementation?
> >
>
> This is already configurable.
>
> You are going to add a new method. This new method must be described in the
> BP
>
> Enrico
>
>
> > On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> > > I support this feature.
> > >
> > > We should design the changes to the APIs.
> > > We need to change EnsemblePlacementPolicy, that is a pluggable API:
> > > users can provide. their own implementation
> >
>
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by Enrico Olivelli <eo...@gmail.com>.
Il Ven 29 Lug 2022, 19:24 Yan Zhao <ho...@apache.org> ha scritto:
> You means we define api in EnsemblePlacementPolicy, and use SPI to load
> special implementation?
>
This is already configurable.
You are going to add a new method. This new method must be described in the
BP
Enrico
> On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> > I support this feature.
> >
> > We should design the changes to the APIs.
> > We need to change EnsemblePlacementPolicy, that is a pluggable API:
> > users can provide. their own implementation
>
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by Yan Zhao <ho...@apache.org>.
You means we define api in EnsemblePlacementPolicy, and use SPI to load special implementation?
On 2022/07/29 15:10:05 Enrico Olivelli wrote:
> I support this feature.
>
> We should design the changes to the APIs.
> We need to change EnsemblePlacementPolicy, that is a pluggable API:
> users can provide. their own implementation
Re: BP-54: Repaired the ledger fragment which ensemble not adhere placement policy.
Posted by Enrico Olivelli <eo...@gmail.com>.
I support this feature.
We should design the changes to the APIs.
We need to change EnsemblePlacementPolicy, that is a pluggable API:
users can provide. their own implementation
please add the design decisions you want to make
Thanks
Enrico
Il giorno ven 29 lug 2022 alle ore 15:31 Yan Zhao
<ho...@apache.org> ha scritto:
>
> @Enrico