You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/02 22:58:47 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
francisguchie opened a new pull request #1143:
URL: https://github.com/apache/fineract/pull/1143
…ment
## Description
https://issues.apache.org/jira/browse/FINERACT-1052#
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1143:
URL: https://github.com/apache/fineract/pull/1143#issuecomment-659524119
Please clean up the commit history on this PR. Or better, jsut create a new fresh branch from latest develop branch and implement the solution from the start..so you have a clean history and not including commits which are already on develop branch. Do you understand me?
Have you tried to do a `git pull --rebase origin develop`, when you are on this feature branch? If the build on Travis is not green and git history is not clean, we cant even review the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1143:
URL: https://github.com/apache/fineract/pull/1143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1143:
URL: https://github.com/apache/fineract/pull/1143#issuecomment-653763629
Failing due to spotless errors:
Run './gradlew spotlessApply' to fix these violations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1143:
URL: https://github.com/apache/fineract/pull/1143#issuecomment-659646777
@awasum , i agree with you, but i will redo a new PR. I tried all the options you have suggested. let me close this PR and raise another one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1143:
URL: https://github.com/apache/fineract/pull/1143#issuecomment-653942322
@awasum and @thesmallstar
do i raise another PR for this ? the failure is more than just the spotlessApply i see non-used importations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1143: FINERACT-1052 global configuration to enable or disable loan Over Pay…
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1143:
URL: https://github.com/apache/fineract/pull/1143#issuecomment-662703409
==> #1186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org