You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/07 10:56:29 UTC
[GitHub] [dubbo-go-pixiu] mark4z opened a new pull request #294: 0.4.0
mark4z opened a new pull request #294:
URL: https://github.com/apache/dubbo-go-pixiu/pull/294
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #294: 0.4.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #294:
URL: https://github.com/apache/dubbo-go-pixiu/pull/294#issuecomment-962593468
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#294](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5407d7e) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/24d579c64a87a078b9374127092f3da2fc938a75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24d579c) will **increase** coverage by `0.01%`.
> The diff coverage is `35.34%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
+ Coverage 33.98% 33.99% +0.01%
===========================================
Files 61 61
Lines 3160 3159 -1
===========================================
Hits 1074 1074
+ Misses 1974 1973 -1
Partials 112 112
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...egistry/registry/zookeeper/application\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fbGlzdGVuZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/client/http/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL3Jlc3BvbnNlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/request.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXF1ZXN0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <ø> (ø)` | |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (ø)` | |
| [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <ø> (ø)` | |
| [pkg/context/http/writer.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC93cml0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [24d579c...5407d7e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] mark4z closed pull request #294: 0.4.0
Posted by GitBox <gi...@apache.org>.
mark4z closed pull request #294:
URL: https://github.com/apache/dubbo-go-pixiu/pull/294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #294: 0.4.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #294:
URL: https://github.com/apache/dubbo-go-pixiu/pull/294#issuecomment-962593468
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#294](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8350ee) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/24d579c64a87a078b9374127092f3da2fc938a75?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24d579c) will **increase** coverage by `8.78%`.
> The diff coverage is `41.70%`.
> :exclamation: Current head e8350ee differs from pull request most recent head 5407d7e. Consider uploading reports for the commit 5407d7e to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #294 +/- ##
===========================================
+ Coverage 33.98% 42.77% +8.78%
===========================================
Files 61 33 -28
Lines 3160 1660 -1500
===========================================
- Hits 1074 710 -364
+ Misses 1974 864 -1110
+ Partials 112 86 -26
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/client/client.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9jbGllbnQuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/client/dubbo/option.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9vcHRpb24uZ28=) | `0.00% <0.00%> (-64.90%)` | :arrow_down: |
| [pkg/client/http/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL3Jlc3BvbnNlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/request.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXF1ZXN0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/client/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9yZXNwb25zZS5nbw==) | `0.00% <ø> (ø)` | |
| [pkg/context/http/writer.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC93cml0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [pkg/proxy/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3h5L2xpc3RlbmVyLmdv) | `20.00% <0.00%> (ø)` | |
| [pkg/proxy/proxy\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3h5L3Byb3h5X3N0YXJ0Lmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/registry/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3JlZ2lzdHJ5L3V0aWwuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `12.79% <4.00%> (+6.60%)` | :arrow_up: |
| ... and [71 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [24d579c...5407d7e](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/294?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org