You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/05/10 14:31:54 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #671: Bucketized Bloom Filter checking

vinothchandar commented on a change in pull request #671: Bucketized Bloom Filter checking
URL: https://github.com/apache/incubator-hudi/pull/671#discussion_r282909423
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieIndexConfig.java
 ##########
 @@ -47,6 +47,15 @@
   public static final String DEFAULT_BLOOM_INDEX_USE_CACHING = "true";
   public static final String BLOOM_INDEX_TREE_BASED_FILTER_PROP = "hoodie.bloom.index.use.treebased.filter";
   public static final String DEFAULT_BLOOM_INDEX_TREE_BASED_FILTER = "true";
+  // On by default. Once stable, we will remove the other mode.
+  public static final String BLOOM_INDEX_BUCKETIZED_CHECKING_PROP = "hoodie.bloom.index.bucketized.checking";
 
 Review comment:
   added TODO.. like to keep it checking, since there are more than 1 check .. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services