[GitHub] sijie commented on a change in pull request #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead
URL: https://github.com/apache/incubator-pulsar/pull/1365#discussion_r173994856
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicsConsumerImpl.java
 ##########
 @@ -726,26 +724,35 @@ private boolean topicNameValid(String topicName) {
     }
 
     // handling failure during subscribe new topic, unsubscribe success created partitions
-    private void handleSubscribeOneTopicError(String topicName, Throwable error) {
-        log.warn("[{}] Failed to subscribe for topic [{}] in topics consumer ", topic, topicName, error.getMessage());
+    private void handleSubscribeOneTopicError(String topicName, Throwable error, CompletableFuture<Void> subscribeFuture) {
+        log.warn("[{}] Failed to subscribe for topic [{}] in topics consumer {}", topic, topicName, error.getMessage());
+        topics.remove(topicName);
 
 Review comment:
   any reason that topic is removed before closing the actual consumers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services