You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/02/19 14:12:49 UTC
Review Request 43764: Extended the actual shutdown timeout for
executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43764/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-1571
https://issues.apache.org/jira/browse/MESOS-1571
Repository: mesos
Description
-------
If the executor provides signal escalation timeout, we account for
it in both containerizer and the executor library. This is done to
ensure such executors get enough time to clean up.
Diffs
-----
src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1
src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3
Diff: https://reviews.apache.org/r/43764/diff/
Testing
-------
`make check` on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 43764: Extended the actual shutdown timeout for
executors.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43764/#review119886
-----------------------------------------------------------
src/slave/slave.cpp (line 3682)
<https://reviews.apache.org/r/43764/#comment181279>
I think here may also need guarantee that the task command signal_escalation_timeout > 0
- Guangya Liu
On 二月 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43764/
> -----------------------------------------------------------
>
> (Updated 二月 19, 2016, 1:12 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the executor provides signal escalation timeout, we account for
> it in both containerizer and the executor library. This is done to
> ensure such executors get enough time to clean up.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1
> src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3
>
> Diff: https://reviews.apache.org/r/43764/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 43764: Extended the actual shutdown timeout for
executors.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43764/#review119887
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43757, 43758, 43759, 43760, 43761, 43762, 43763, 43764]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 1:12 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43764/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 1:12 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-1571
> https://issues.apache.org/jira/browse/MESOS-1571
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the executor provides signal escalation timeout, we account for
> it in both containerizer and the executor library. This is done to
> ensure such executors get enough time to clean up.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 83dbee9dd2d9a4e7ebf395c8070bc7f9f8412ef1
> src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3
>
> Diff: https://reviews.apache.org/r/43764/diff/
>
>
> Testing
> -------
>
> `make check` on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>