You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "varunsh-xilinx (via GitHub)" <gi...@apache.org> on 2023/12/13 20:25:39 UTC

[I] [Bug] CMake minimum version too low [tvm]

varunsh-xilinx opened a new issue, #16233:
URL: https://github.com/apache/tvm/issues/16233

   The CMake version in `CMakeLists.txt` [here](https://github.com/apache/tvm/blob/main/CMakeLists.txt#L1) is too low at 3.18. New changes require at least 3.20.0:
   
   * In `ubuntu_install_cmake_source.sh`, the [default version is set](https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_cmake_source.sh#L23-L28) to 3.20.0 with a note that LLVM 16+ requires it.
   * #16081 adds `cmake_path` to `cmake/utils/FindLLVM.cmake`. This [command ](https://cmake.org/cmake/help/latest/command/cmake_path.html)exists in CMake 3.20+.
   
   ### Expected behavior
   
   If the CMake version is unsupported, it should fail at `cmake_minimum_required()`.
   
   ### Actual behavior
   
   The build failed in `FindLLVM.cmake` when `cmake_path` couldn't be found as a CMake command:
   ```
   CMake Error at cmake/utils/FindLLVM.cmake:121 (cmake_path):
     Unknown CMake command "cmake_path".
   Call Stack (most recent call first):
     cmake/modules/LLVM.cmake:31 (find_llvm)
     CMakeLists.txt:528 (include)
   ```
   
   ### Environment
   
   Tried on a custom Ubuntu 20.04 container with TVM commit a9fcac1a47f4b57c1d9d828c7ed1d77452b02cc5.
   
   ### Steps to reproduce
   
   Attempt to build TVM with CMake 3.19.1.
   
   ### Triage
   
   Please refer to the list of label tags [here](https://github.com/apache/tvm/wiki/Issue-Triage-Labels) to find the relevant tags and add them below in a bullet format (example below).
   
   * needs-triage
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] CMake minimum version too low [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed issue #16233: [Bug] CMake minimum version too low
URL: https://github.com/apache/tvm/issues/16233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org