You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/11 14:51:57 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `5.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 70.59% +5.00%
==========================================
Files 585 400 -185
Lines 31046 12856 -18190
Branches 3277 3180 -97
==========================================
- Hits 20364 9076 -11288
+ Misses 10501 3665 -6836
+ Partials 181 115 -66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.07% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `61.22% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
| [superset/charts/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | | |
| [superset/examples/paris.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | | |
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
| [...t-frontend/src/explore/controlPanels/EventFlow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9FdmVudEZsb3cuanN4) | | |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | | |
| ... and [323 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org