You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2023/01/17 16:12:49 UTC

[GitHub] [thrift] emmenlau commented on pull request #2745: lib: cpp: transport: file descriptor leak in TServerSocket::close()

emmenlau commented on PR #2745:
URL: https://github.com/apache/thrift/pull/2745#issuecomment-1385668209

   @cfriedt , I guess this is beyond your current scope, but for the sake of clean code, would it not be better to bind the `std::shared_ptr` to a custom destructor that calls `::THRIFT_CLOSESOCKET` on the socket upon destruction? And then again, why is the operating system not doing that in the first place?
   
   Please let me know if I'm completely on the wrong track here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org