You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ap-Codkelden (via GitHub)" <gi...@apache.org> on 2026/02/11 06:33:29 UTC
[I] Wrong language code for Ukrainian in CSS [superset]
ap-Codkelden opened a new issue, #37875:
URL: https://github.com/apache/superset/issues/37875
## Screenshot
<img width="274" height="144" alt="Image" src="https://github.com/user-attachments/assets/6a5bbc02-c604-4536-856e-b9eee320c3ff" />
## Description
If Ukrainian language is enabled as interface language, there is no Ukrainian flag displayed.
## Design input
CSS class for Ukrainian flag from Superset is `<i class flag uk>`, with corresponding CSS selector `background: url(../images/flags16.png)` In `flags16.css`.
But entry for `"uk"` is absent in the CSS file `flags16.css`. Instead of it, an entry
.f16 .ua{background-position:0 -3632px;}
is present on the line 229 of this file.
ISO-639-2 language code for Ukrainian is `ua`. So please bring into one line CSS file and page source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "yash-1104github (via GitHub)" <gi...@apache.org>.
yash-1104github commented on issue #37875:
URL: https://github.com/apache/superset/issues/37875#issuecomment-3885660807
@bgreenlee i love to work on this issue, could you please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #37875: Wrong language code for Ukrainian in CSS
URL: https://github.com/apache/superset/issues/37875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #37875:
URL: https://github.com/apache/superset/issues/37875#issuecomment-4699415513
#39593 corrected the Ukrainian flag code (uk -> ua) and merged, so closing this. Ping me if anything still looks off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "andriiiiiko (via GitHub)" <gi...@apache.org>.
andriiiiiko commented on issue #37875:
URL: https://github.com/apache/superset/issues/37875#issuecomment-4304629235
This has been fixed in PR #39593. Please review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on issue #37875:
URL: https://github.com/apache/superset/issues/37875#issuecomment-3891141790
@yash-1104github I've assigned you, thanks for your volunteering!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Wrong language code for Ukrainian in CSS [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #37875:
URL: https://github.com/apache/superset/issues/37875#issuecomment-3882639685
<!-- Greeting -->
Hi @ap-Codkelden! I'm [Dosu](https://go.dosu.dev/dosubot) and Iām helping the superset team.
<!-- Answer -->
The issue is caused by a mismatch: Superset uses the ISO 639-1 language code 'uk' for Ukrainian, but the CSS only defines a flag for the country code 'ua', so the flag doesn't display. You can fix this in one of two ways:
1. Add a CSS rule for `.f16 .uk` in `flags16.css` with the same background position as `.ua`:
```css
.f16 .uk { background-position: 0 -3632px; }
```
This will make the Ukrainian flag appear when the UI uses `<i class="flag uk">`.
2. Update the language/flag mapping in Superset's config to use 'ua' as the flag code for Ukrainian:
```python
LANGUAGES = {
"uk": {"flag": "ua", "name": "Ukrainian"},
# ... other languages ...
}
```
This will make the UI use `<i class="flag ua">`, matching the existing CSS.
Either approach will align the CSS and the page source so the Ukrainian flag displays correctly in the language selector. Superset expects explicit mapping between language codes and flag codes, so keeping them consistent is best practice. For reference, English uses language code 'en' and flag code 'us' in Superset's config and CSS ([source](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/config.py#L382-L403)).
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
---
<sup>How did I do? [Good](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=hallucination) | [Report š](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/0753711e-12ff-4dd0-8460-3d43c5647886?feedback_type=other)</sup>
[](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=The%20issue%20is%20caused%20by%20a%20mismatch%3A%20Superset%20uses%20the%20ISO%20639-1%20language%20code%20%27uk%27%20for%20Ukrainian%2C%20but%20the%20CSS%20only%20defines%20a%20flag%20for%20the%20country%20code%20%27ua%27%2C%20so%20the%20flag%20doesn%27t%20display.%20You%20can%20fix%20this%20in%20one%20of%20two%20ways%3A%0A%0A1.%20Add%20a%20CSS%20rule%20for%20%60.f16%20.uk%60%20in%20%60flags16.css%60%20with%20the%20same%20background%20position%20as%20%60.ua%60%3A%0A%20%20%20%60%60%60css%0A%20%20%20.f16%20.uk%20%7B%20background-position%3A%200%20-3632px%3B%20%7D%0A%20%20%20%60%60%60%0A%20%20%20This%20will%20make%20the%20Ukrainian%20flag%20appear%20when%20the%20UI%20uses%20%60%3Ci%20class%3D%22flag%20uk%22%3E%60.%0A%0A2.%20Update%20the%20language/fl
ag%20mapping%20in%20Superset%27s%20config%20to%20use%20%27ua%27%20as%20the%20flag%20code%20for%20Ukrainian%3A%0A%20%20%20%60%60%60python%0A%20%20%20LANGUAGES%20%3D%20%7B%0A%20%20%20%20%20%20%20%22uk%22%3A%20%7B%22flag%22%3A%20%22ua%22%2C%20%22name%22%3A%20%22Ukrainian%22%7D%2C%0A%20%20%20%20%20%20%20%23%20...%20other%20languages%20...%0A%20%20%20%7D%0A%20%20%20%60%60%60%0A%20%20%20This%20will%20make%20the%20UI%20use%20%60%3Ci%20class%3D%22flag%20ua%22%3E%60%2C%20matching%20the%20existing%20CSS.%0A%0AEither%20approach%20will%20align%20the%20CSS%20and%20the%20page%20source%20so%20the%20Ukrainian%20flag%20displays%20correctly%20in%20the%20language%20selector.%20Superset%20expects%20explicit%20mapping%20between%20language%20codes%20and%20flag%20codes%2C%20so%20keeping%20them%20consistent%20is%20best%20practice.%20For%20reference%2C%20English%20uses%20language%20code%20%27en%27%20and%20flag%20code%20%27us%27%20in%20Superset%27s%20config%20and%20CSS%20%28%5Bsource%5D%28https%3A//github.co
m/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/config.py%23L382-L403%29%29.) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/37875)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org