You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/09/12 16:08:57 UTC
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11432
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
IMPALA-7487: fix stress test handling of AC memory rejection
The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.
Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.
I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.
Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
---
M tests/stress/concurrent_select.py
1 file changed, 44 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/11432/1
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 15:38:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 15:39:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
IMPALA-7487: fix stress test handling of AC memory rejection
The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.
Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.
I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.
Testing:
Ran TPC-H stress test locally, which previous was reliably hitting the
error described in the JIRA.
Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Reviewed-on: http://gerrit.cloudera.org:8080/11432
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: David Knupp <dk...@cloudera.com>
---
M tests/stress/concurrent_select.py
1 file changed, 44 insertions(+), 17 deletions(-)
Approvals:
David Knupp: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/650/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Sep 2018 16:43:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 04:43:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3158/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 01:15:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/673/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 01:48:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 5:
Thanks David!
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:09:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py@248
PS2, Line 248: excludes
> Nit: exclusive
Done
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py@260
PS2, Line 260: def __repr__(self):
> Technically, I think this should be __str__, not __repr__.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 01:14:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py@248
PS2, Line 248: excludes
Nit: exclusive
http://gerrit.cloudera.org:8080/#/c/11432/2/tests/stress/concurrent_select.py@260
PS2, Line 260: def __repr__(self):
Technically, I think this should be __str__, not __repr__.
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 18:04:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11432 )
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 15:39:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello David Knupp,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11432
to look at the new patch set (#2).
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
IMPALA-7487: fix stress test handling of AC memory rejection
The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.
Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.
I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.
Testing:
Ran TPC-H stress test locally, which previous was reliably hitting the
error described in the JIRA.
Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
---
M tests/stress/concurrent_select.py
1 file changed, 44 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/11432/2
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-7487: fix stress test handling of AC memory rejection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11432
to look at the new patch set (#3).
Change subject: IMPALA-7487: fix stress test handling of AC memory rejection
......................................................................
IMPALA-7487: fix stress test handling of AC memory rejection
The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.
Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.
I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.
Testing:
Ran TPC-H stress test locally, which previous was reliably hitting the
error described in the JIRA.
Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
---
M tests/stress/concurrent_select.py
1 file changed, 44 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/11432/3
--
To view, visit http://gerrit.cloudera.org:8080/11432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>