[jira] [Resolved] (GEODE-5803) Code Cleanup: remove pathological geode-core test source set assignment.

["Patrick Rhomberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Rhomberg resolved GEODE-5803.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

> Code Cleanup: remove pathological geode-core test source set assignment.
> ------------------------------------------------------------------------
>
>                 Key: GEODE-5803
>                 URL: https://issues.apache.org/jira/browse/GEODE-5803
>             Project: Geode
>          Issue Type: Sub-task
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> {noformat}
> // geode-core/build.gradle:217-223
> dependencies {
>   // Integration Tests
>   integrationTestCompile sourceSets.test.output
>   // Distributed Tests
>   distributedTestCompile sourceSets.integrationTest.output
> }
> {noformat}
> The above is a severe gradle anti-pattern.  Source sets should be defined via our testing facets, and any dependences that {{integrationTestCompile}} or {{distributedTestCompile}} required should be explicitly stated.
> At a preliminary glance, this appears to have been done to avoid detangling the tight coupling of {{geode-core:test:org.apache.geode.test.process}}, {{*.test.golden}}, and these classes consumption in other modules.
> A module should not consume another module's test output.  These classes should be promoted to "main" classes within the {{geode-junit}} or {{geode-dunit}} structures, as appropriate.
> Some discussion on this exists in the previous pull request, #2549.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)