[GitHub] rdhabalia commented on issue #1005: Load-balancer consider max-topic threshold on broker-ownership selection

[GitBox <gi...@apache.org>]

rdhabalia commented on issue #1005: Load-balancer consider max-topic threshold on broker-ownership selection
URL: https://github.com/apache/incubator-pulsar/pull/1005#issuecomment-356444345
 
 
   > if the max is reached on a given broker and there are no brokers available?
   
   In that case, load-manager is already [performing broker-selection again](https://github.com/apache/incubator-pulsar/pull/919) without that filter and it selects least loaded broker.
   
   >  though the topics will be shedded whenever there additional brokers will be available?
   
   yes, we can add this variable for load-shedding as well but this helps in very beginning while loading topic at broker which can avoid bundle-unloading after 30 mins. In few usecases, we may want to disable load-shedding  in cluster to avoid in bundle disruption or topic-stuck due to some unloading-bugs. So, it's always good if broker considers max topic limit while selecting broker. 
   
   Actually, main motivation of this change is that broker has certain limit for owning X (eg:60K) number of topics after that broker sees obvious GC as each topic allocates large number of `Rate` and other objects even if topics are idle. we can verify and check in heapdump of broker that owns > 60K topics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services