You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/05 22:13:50 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
thesmallstar opened a new pull request #1156:
URL: https://github.com/apache/fineract/pull/1156
Requires more research and Testing.
If anyone can help me verify if prepared statements are allowed for limit, order by and offset? I have been seen various comments with different opinions and no mention in any official documentation.
I tested this approach with an example in the CentersReadPlatform and it worked as it should, but I am separating this from that PR so as to not to block it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-678566569
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1156:
URL: https://github.com/apache/fineract/pull/1156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639
@thesmallstar remind us where we are with this one? Both #1171 and #1123 (mentioned above) are merged now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639
@thesmallstar remind us where we are with this one? Both #1171 and #1123 (mentioned above) are merged now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1156:
URL: https://github.com/apache/fineract/pull/1156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-717045470
@thesmallstar ping on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-736910360
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-678601025
@thesmallstar this is getting stale. Any updates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-657272679
I will first complete #1171 #1123 and then try to implement this feature in this those two files (in this PR), so that we can review this independently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-662758037
The PRs #1171 and #1123 are blocked by FINERACT-1095. You could still continue here already, if you like - just for the future.
But didn't you loose the `SQLBuidlerTest` you originally had in #1123 when you "split" your work? Hope you still have it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1156: Fineract-1058 added support for limit,offset and orderBy in SQLbuilder
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-691273639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org