You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (JIRA)" <ji...@apache.org> on 2012/07/10 17:59:33 UTC

[jira] [Created] (CB-1020) Patch WP7 cordova.js to use exec() for all calls into native

Filip Maj created CB-1020:
-----------------------------

             Summary: Patch WP7 cordova.js to use exec() for all calls into native
                 Key: CB-1020
                 URL: https://issues.apache.org/jira/browse/CB-1020
             Project: Apache Cordova
          Issue Type: Bug
          Components: CordovaJS, WP7
    Affects Versions: 1.9.0
            Reporter: Filip Maj
            Assignee: Filip Maj
             Fix For: 2.0.0


The DomStorage plugin in WP7's js uses calls directly to {{window.external.Notify}}. Instead, our own plugins should use our bridge abstraction, {{exec}}, to route these calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1020) Patch WP7 cordova.js to use exec() for all calls into native

Posted by "Jesse MacFadyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse MacFadyen resolved CB-1020.
---------------------------------

    Resolution: Fixed
    
> Patch WP7 cordova.js to use exec() for all calls into native
> ------------------------------------------------------------
>
>                 Key: CB-1020
>                 URL: https://issues.apache.org/jira/browse/CB-1020
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS, WP7
>    Affects Versions: 1.9.0
>            Reporter: Filip Maj
>            Assignee: Jesse MacFadyen
>             Fix For: 2.0.0
>
>
> The DomStorage plugin in WP7's js uses calls directly to {{window.external.Notify}}. Instead, our own plugins should use our bridge abstraction, {{exec}}, to route these calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1020) Patch WP7 cordova.js to use exec() for all calls into native

Posted by "Jesse MacFadyen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410581#comment-13410581 ] 

Jesse MacFadyen commented on CB-1020:
-------------------------------------

da5d00b8c70465424ab3d05157e83483422755f5

I did not implement this exactly as defined above.  I added a conditional to only patch the browser when we know that localStorage will fail, ie when document.domain is not available.

https://github.com/purplecabbage/incubator-cordova-js/commit/da5d00b8c70465424ab3d05157e83483422755f5
                
> Patch WP7 cordova.js to use exec() for all calls into native
> ------------------------------------------------------------
>
>                 Key: CB-1020
>                 URL: https://issues.apache.org/jira/browse/CB-1020
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS, WP7
>    Affects Versions: 1.9.0
>            Reporter: Filip Maj
>            Assignee: Jesse MacFadyen
>             Fix For: 2.0.0
>
>
> The DomStorage plugin in WP7's js uses calls directly to {{window.external.Notify}}. Instead, our own plugins should use our bridge abstraction, {{exec}}, to route these calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CB-1020) Patch WP7 cordova.js to use exec() for all calls into native

Posted by "Jesse MacFadyen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse MacFadyen reassigned CB-1020:
-----------------------------------

    Assignee: Jesse MacFadyen  (was: Filip Maj)
    
> Patch WP7 cordova.js to use exec() for all calls into native
> ------------------------------------------------------------
>
>                 Key: CB-1020
>                 URL: https://issues.apache.org/jira/browse/CB-1020
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS, WP7
>    Affects Versions: 1.9.0
>            Reporter: Filip Maj
>            Assignee: Jesse MacFadyen
>             Fix For: 2.0.0
>
>
> The DomStorage plugin in WP7's js uses calls directly to {{window.external.Notify}}. Instead, our own plugins should use our bridge abstraction, {{exec}}, to route these calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira