[jira] [Comment Edited] (SPARK-15015) Log statements lack file name/number

["John-Michael Reed (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291194#comment-15291194 ] 

John-Michael Reed edited comment on SPARK-15015 at 5/19/16 2:44 PM:
--------------------------------------------------------------------

In order for that to happen
a) Someone has to do a system wide change
And
b) People have to approve the system wide change

I would not make this change if it's going to be rejected.

If somebody else approves it and can make the decision about whether to add the class, I would be willing to implement it.


was (Author: johnreed2):
In order for that to happen
a) Someone has to do a system wide change
And
b) People have to approve the system wide change

I would not make this change if it's going to be rejected. Also, there is the matter of copy-pasting in a single class for appending a clickable stack trace versus importing an entire jar file. If you don't want things like printing formatted containers or adding line wraps at the 100 character mark or printing the names of variables in addition to their values, it would take up less space just copying over Pos.

If somebody else approves it and can make the decision about whether to add the class, I would be willing to implement it.

> Log statements lack file name/number
> ------------------------------------
>
>                 Key: SPARK-15015
>                 URL: https://issues.apache.org/jira/browse/SPARK-15015
>             Project: Spark
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.6.1
>         Environment: All
>            Reporter: John-Michael Reed
>            Priority: Trivial
>              Labels: debug, log
>
> I would like it if the Apache Spark project had file names and line numbers in its log statements like this:
> http://i.imgur.com/4hvGQ0t.png
> The example uses my library, http://johnreedlol.github.io/scala-trace-debug/, but https://github.com/lihaoyi/sourcecode is also useful for this purpose. 
> The real benefit in doing this is because the user of an IDE can jump to the location of a log statement without having to set breakpoints.
> http://s29.postimg.org/ud0knou1j/debug_Screenshot_Crop.png
> Note that the arrow will go to the next log statement if each log statement is hyperlinked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org