Re: [PR] feat: Implement read support for String/Binary View types [arrow-nanoarrow]

["WillAyd (via GitHub)" <gi...@apache.org>]

WillAyd commented on code in PR #596:
URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1744021640


##########
src/nanoarrow/common/inline_array.h:
##########
@@ -914,6 +914,29 @@ static inline double ArrowArrayViewGetDoubleUnsafe(
   }
 }
 
+enum { ARROW_BINARY_VIEW_INLINE_SIZE = 12 };

Review Comment:
   I originally had these as macros but the Cython generator did not like that. However, it doesn't appear to like the enum hack either.
   
   Any ideas on what the best practice for the library here is @paleolimbot ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org