You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/07/24 05:29:59 UTC
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/650
TAJO-1704: Apply ComparableTuple to *AggregateExec.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1704
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #650
----
commit a14b5e2f8cc7af8ce2439f02482d5cf0eac8373f
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-07-24T03:29:05Z
TAJO-1704: Apply ComparableTuple to *AggregateExec.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik closed the pull request at:
https://github.com/apache/tajo/pull/650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/650#issuecomment-124808384
Hi @hyunsik
Could you explain why you changed queries and results for window function test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/650#issuecomment-124800448
+1
LGTM! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/650#issuecomment-164321677
@hyunsik are you working on this issue? If not, please close this PR. We can open again when we need later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/650#issuecomment-165224073
closed. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1704: Apply ComparableTuple to *AggregateE...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/650#issuecomment-124345219
Just rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---