You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by gi...@git.apache.org on 2017/08/09 08:02:59 UTC

[GitHub] sijie commented on a change in pull request #420: Issue 419: dockerfile - add script to get GPG_KEY

sijie commented on a change in pull request #420: Issue 419: dockerfile - add script to get GPG_KEY
URL: https://github.com/apache/bookkeeper/pull/420#discussion_r132081882
 
 

 ##########
 File path: docker/Dockerfile
 ##########
 @@ -31,7 +30,7 @@ ENV BK_USER=bookkeeper
 # Download Apache Bookkeeper, untar and clean up
 RUN set -x \
     && adduser "${BK_USER}" \
-    && yum install -y java-1.8.0-openjdk-headless wget bash python md5sum sha1sum sudo \
 
 Review comment:
   any reason removing `md5sum` and `sha1sum`? I think we need these two commands. even if these two commands are pre-packaged in the base image, there is no harm to install these two commands, right? It actually make the dependencies clear, no?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services