You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Vaibhav Puranik (JIRA)" <ji...@apache.org> on 2010/10/18 20:05:22 UTC
[jira] Created: (HBASE-3118) HBaseAdmin.createTable and modifyTable
should have a family check
HBaseAdmin.createTable and modifyTable should have a family check
-----------------------------------------------------------------
Key: HBASE-3118
URL: https://issues.apache.org/jira/browse/HBASE-3118
Project: HBase
Issue Type: Improvement
Environment: 0.20.6, Linux, Java 1.6+
Reporter: Vaibhav Puranik
Currently HBaseAdmin.modifyTable does not check whether any family is supplied or not. I can execute this method without supplying any families and that puts the table in inconsistent state.
In my opinion, modifyTable should let you modifyTable without overwriting. But looks like it doesn't do that. This can be very dangerous as you can end up overwriting a table in production and loose data. But if we are going to keep the behavior then at least some checks should be added to make it safer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3118) HBaseAdmin.createTable and
modifyTable should have a family check
Posted by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922214#action_12922214 ]
Kannan Muthukkaruppan commented on HBASE-3118:
----------------------------------------------
+1.
On a related note, if you use alter table to change the settings for a CF, you must provide all the non-default settings once again even if you don't want to change them.
For example, if you had VERSION => 5, COMPRESSION => 'NONE' on a column family, and you did an alter, and provided just COMPRESSION => 'LZO', then the VERSION setting reverts back to the default (3).
It would be nice if the "alter" read the old state, and applied only the delta change.
> HBaseAdmin.createTable and modifyTable should have a family check
> -----------------------------------------------------------------
>
> Key: HBASE-3118
> URL: https://issues.apache.org/jira/browse/HBASE-3118
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.20.6
> Environment: 0.20.6, Linux, Java 1.6+
> Reporter: Vaibhav Puranik
>
> Currently HBaseAdmin.modifyTable does not check whether any family is supplied or not. I can execute this method without supplying any families and that puts the table in inconsistent state.
> In my opinion, modifyTable should let you modifyTable without overwriting. But looks like it doesn't do that. This can be very dangerous as you can end up overwriting a table in production and loose data. But if we are going to keep the behavior then at least some checks should be added to make it safer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3118) HBaseAdmin.createTable and
modifyTable should have a family check
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922234#action_12922234 ]
Jonathan Gray commented on HBASE-3118:
--------------------------------------
@Kannan, Yeah HBASE-2984 is currently a blocker against 0.90 to do just that
> HBaseAdmin.createTable and modifyTable should have a family check
> -----------------------------------------------------------------
>
> Key: HBASE-3118
> URL: https://issues.apache.org/jira/browse/HBASE-3118
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.20.6
> Environment: 0.20.6, Linux, Java 1.6+
> Reporter: Vaibhav Puranik
>
> Currently HBaseAdmin.modifyTable does not check whether any family is supplied or not. I can execute this method without supplying any families and that puts the table in inconsistent state.
> In my opinion, modifyTable should let you modifyTable without overwriting. But looks like it doesn't do that. This can be very dangerous as you can end up overwriting a table in production and loose data. But if we are going to keep the behavior then at least some checks should be added to make it safer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-3118) HBaseAdmin.createTable and modifyTable
should have a family check
Posted by "Vaibhav Puranik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vaibhav Puranik updated HBASE-3118:
-----------------------------------
Affects Version/s: 0.20.6
> HBaseAdmin.createTable and modifyTable should have a family check
> -----------------------------------------------------------------
>
> Key: HBASE-3118
> URL: https://issues.apache.org/jira/browse/HBASE-3118
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.20.6
> Environment: 0.20.6, Linux, Java 1.6+
> Reporter: Vaibhav Puranik
>
> Currently HBaseAdmin.modifyTable does not check whether any family is supplied or not. I can execute this method without supplying any families and that puts the table in inconsistent state.
> In my opinion, modifyTable should let you modifyTable without overwriting. But looks like it doesn't do that. This can be very dangerous as you can end up overwriting a table in production and loose data. But if we are going to keep the behavior then at least some checks should be added to make it safer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.