You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by pd...@apache.org on 2016/04/24 18:14:48 UTC
svn commit: r1740706 -
/felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java
Author: pderop
Date: Sun Apr 24 16:14:47 2016
New Revision: 1740706
URL: http://svn.apache.org/viewvc?rev=1740706&view=rev
Log:
Fixed a bug in the test (the configuration pid was not set, this could potentially cause a NPE in ConfigurationEventImpl.compareTo() method.
Modified:
felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java
Modified: felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java
URL: http://svn.apache.org/viewvc/felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java?rev=1740706&r1=1740705&r2=1740706&view=diff
==============================================================================
--- felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java (original)
+++ felix/trunk/dependencymanager/org.apache.felix.dependencymanager/test/test/ConfigurationTest.java Sun Apr 24 16:14:47 2016
@@ -38,6 +38,7 @@ public class ConfigurationTest extends T
// Create our configuration dependency
final ConfigurationDependencyImpl conf = new ConfigurationDependencyImpl();
+ conf.setPid("some.pid");
// Create another required dependency
final SimpleServiceDependency requiredDependency = new SimpleServiceDependency();
@@ -120,7 +121,8 @@ public class ConfigurationTest extends T
conf.updated(props);
}
catch (ConfigurationException err) {
- warn("got expected configuration error");
+ warn("got unexpected configuration error");
+ e.throwable(err);
}
// This time, our component should be started properly.