You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/04/14 16:17:49 UTC

[GitHub] [gobblin] autumnust commented on a change in pull request #3256: GOBBLIN-1420: Log uncaught exceptions from StreamModelTaskRunner

autumnust commented on a change in pull request #3256:
URL: https://github.com/apache/gobblin/pull/3256#discussion_r613390804



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/StreamModelTaskRunner.java
##########
@@ -151,9 +152,11 @@ protected void run() throws Exception {
         this.task.configureStreamingFork(fork);
       }
     }
-    new Thread(() -> {

Review comment:
       Just curious: What was the motivation to put this line alone in a new thread? isn't the `connect()` an async call ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org