You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/12/17 10:52:44 UTC

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #7147: IGNITE-12442: Fix unnecessary sync on PagesCache.

alex-plekhanov commented on a change in pull request #7147: IGNITE-12442: Fix unnecessary sync on PagesCache.
URL: https://github.com/apache/ignite/pull/7147#discussion_r358723568
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/freelist/PagesList.java
 ##########
 @@ -2033,6 +2033,9 @@ public synchronized boolean add(long pageId) {
             int stripeIdx = (int)pageId & (STRIPES_COUNT - 1);
 
             synchronized (stripeLocks[stripeIdx]) {
+                if (size >= MAX_SIZE)
 
 Review comment:
   It's a redundant check. There already exists a stripe size check under the lock.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services