You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/01/07 15:30:23 UTC
[I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
kevinjqliu opened a new issue, #1492:
URL: https://github.com/apache/iceberg-python/issues/1492
### Feature Request / Improvement
In the [write properties](https://iceberg.apache.org/docs/1.6.0/configuration/?h=write.data.path#write-properties) section
#1452 adds support for LocationProvider https://github.com/apache/iceberg-python/pull/1452#discussion_r1893970505
Similar issue, #161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2626918246
I'm also happy to pick this up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "jiakai-li (via GitHub)" <gi...@apache.org>.
jiakai-li commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2576010415
I raised a duplicated one, which is closed now. Can I work on this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2576027138
BTW this is how java side is done https://grep.app/search?q=WRITE_DATA_LOCATION&filter[repo][0]=apache/iceberg&filter[path][0]=core/src/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2584575339
#1452 is merged, we can now work on adding support for the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #1492: [feature] Add support for `write.data.path` and `write.metadata.path`
URL: https://github.com/apache/iceberg-python/issues/1492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "jiakai-li (via GitHub)" <gi...@apache.org>.
jiakai-li commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2581073509
Sure, that makes sense to me, thank you @smaheshwar-pltr , :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2644109473
I'd like to pick up the `write.metadata.path` impl if no one has already!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "smaheshwar-pltr (via GitHub)" <gi...@apache.org>.
smaheshwar-pltr commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2578312852
Thanks for volunteering @jiakai-li! Happy to review the `LocationProvider`-related changes for `write.data.path` if it'd help 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2644116402
sure @geruh thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "jiakai-li (via GitHub)" <gi...@apache.org>.
jiakai-li commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2579084317
Hey @smaheshwar-pltr , thanks for the offer! I hadn’t realized this feature is closely tied to LocationProvider. After looking into it, I think it could fit well with the changes you’re already working on. Would you like to handle it as part of your update, or would you prefer I continue working on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2659907096
All done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "smaheshwar-pltr (via GitHub)" <gi...@apache.org>.
smaheshwar-pltr commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2580114664
> I hadn’t realized this feature is closely tied to LocationProvider. After looking into it, I think it could fit well with the changes you’re already working on. Would you like to handle it as part of your update, or would you prefer I continue working on it?
Good suggestion @jiakai-li - I expressed my thoughts here: https://github.com/apache/iceberg-python/pull/1452#discussion_r1893970505. I'd prefer to keep https://github.com/apache/iceberg-python/pull/1452 as just what's needed to address the issue linked on it because:
- as is, there are important discussions to be had regarding location provision alone, e.g. https://github.com/apache/iceberg-python/pull/1452#discussion_r1899070323 + https://github.com/apache/iceberg-python/pull/1452#pullrequestreview-2528159350, and
- `write.metadata.path`, which feels like it should be supported along with `write.data.path`, is (as far as I understand) quite separate from those changes. IMO, we'd then doing too many things in that PR.
I'd prefer that both of these new write options be tackled together in a follow-up PR, that closes this issue - let me know how this sounds to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature] Add support for `write.data.path` and `write.metadata.path` [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1492:
URL: https://github.com/apache/iceberg-python/issues/1492#issuecomment-2576025504
assigned to you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org