You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2013/11/26 13:02:14 UTC
svn commit: r1545629 -
/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
Author: markt
Date: Tue Nov 26 12:02:14 2013
New Revision: 1545629
URL: http://svn.apache.org/r1545629
Log:
FindBugs: Use static inner class, unnecessary allocation
Modified:
commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
Modified: commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java?rev=1545629&r1=1545628&r2=1545629&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java Tue Nov 26 12:02:14 2013
@@ -1796,26 +1796,17 @@ public class TestGenericKeyedObjectPool
config.setTestWhileIdle(true);
config.setTimeBetweenEvictionRunsMillis(-1);
- final GenericKeyedObjectPool<Integer, Object> pool = new GenericKeyedObjectPool<Integer, Object>(
- new ObjectFactory(),
- config);
+ final GenericKeyedObjectPool<Integer, Object> pool =
+ new GenericKeyedObjectPool<Integer, Object>(
+ new ObjectFactory(), config);
// Allocate both objects with this thread
- @SuppressWarnings("unused")
- Object object1 = pool.borrowObject(Integer.valueOf(1));
+ pool.borrowObject(Integer.valueOf(1)); // object1
Object object2 = pool.borrowObject(Integer.valueOf(1));
// Cause a thread to block waiting for an object
- ExecutorService executorService = Executors.newSingleThreadExecutor(new ThreadFactory() {
-
- @Override
- public Thread newThread(Runnable r) {
- Thread t = new Thread(r);
- t.setDaemon(true);
- return t;
- }
- });
-
+ ExecutorService executorService =
+ Executors.newSingleThreadExecutor(new DaemonThreadFactory());
final Semaphore signal = new Semaphore(0);
Future<Exception> result = executorService.submit(new Callable<Exception>() {
@@ -1852,6 +1843,17 @@ public class TestGenericKeyedObjectPool
}
}
+
+ private static class DaemonThreadFactory implements ThreadFactory {
+ @Override
+ public Thread newThread(Runnable r) {
+ Thread t = new Thread(r);
+ t.setDaemon(true);
+ return t;
+ }
+ }
+
+
/**
* Verify that threads waiting on a depleted pool get served when a checked out object is
* invalidated.