[GitHub] [accumulo] EdColeman commented on a diff in pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#discussion_r1123491725


##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java:
##########
@@ -42,13 +43,13 @@ public class SeekableByteArrayInputStream extends InputStream {
   @SuppressFBWarnings(value = "VO_VOLATILE_REFERENCE_TO_ARRAY",
       justification = "see explanation above")
   private volatile byte[] buffer;
-  private int cur;
-  private int max;
+  private final AtomicInteger cur;
+  private final AtomicInteger max;

Review Comment:
   The build kicked off with maven 3.9.0 - there is an issue with that maven version that removed a dependency (plex) that used to be provided.  There are more details in the Accumulo slack channel, but the bottom line is that plugins need updated to use maven 3.9.0, or we force the actions to use an older maven version.  The fix for the plugins is in progress, but not sure when they will be released.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org