You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/13 19:10:42 UTC
[GitHub] [accumulo-testing] DomGarguilo opened a new pull request, #243: Update license headers to match main accumulo project
DomGarguilo opened a new pull request, #243:
URL: https://github.com/apache/accumulo-testing/pull/243
Similiar to https://github.com/apache/accumulo/pull/2774. Copied and edited the description of that PR:
* Update license header template to use https (this has been discussed
at length on the legal mailing list and elsewhere, and is an
acceptable URL to reference the license text that the rat plugin has
been made to support)
* Update to rat 0.15
* Find other uses of http and replace with https unless it breaks a link
or is a namespace identifier or other situation where http is required
* Use the standardized format of the license header text for the
markdown files
https://github.com/apache/accumulo/pull/2774 standardized the headers in the .gitignore files however there are no headers in those files in accumulo-testing. Not sure if they should be added here or if they should be left alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1278144412
> > Sounds good, I'll try to do that.
>
> No worries. I did it in #244. After that, and the subsequent commit is merged, we can pick up the remaining that you may have caught here, that weren't part of headers.
Are you planning to merge the subsequent commit containing the automatically applied headers or should I do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1278087726
> @DomGarguilo I don't think I can review a changeset like this, with 358 files changed. I suspect most of these are automatic changes generated from a base configuration change. if you can separate out the configuration change that caused all the files to be changed, I'll review that, and then you can just add a separate commit that does only the automatic changes generated from the reviewed changes.
Sounds good, I'll try to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1278195921
> Are you planning to merge the subsequent commit containing the automatically applied headers or should I do that?
I've got it. I am done now. If there's anything else remaining in this PR that needs to be done, this can be rebased onto the new main. Otherwise, this can be closed if there's nothing left to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1279085803
Looks like all my changes were included in commits already merged into main. Closing this as already completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo closed pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
DomGarguilo closed pull request #243: Update license headers to match main accumulo project
URL: https://github.com/apache/accumulo-testing/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1278086328
@DomGarguilo I don't think I can review a changeset like this, with 358 files changed. I suspect most of these are automatic changes generated from a base configuration change. if you can separate out the configuration change that caused all the files to be changed, I'll review that, and then you can just add a separate commit that does only the automatic changes generated from the reviewed changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #243: Update license headers to match main accumulo project
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #243:
URL: https://github.com/apache/accumulo-testing/pull/243#issuecomment-1278122598
> Sounds good, I'll try to do that.
No worries. I did it in #244. After that, and the subsequent commit is merged, we can pick up the remaining that you may have caught here, that weren't part of headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org