[GitHub] [zookeeper] maoling commented on issue #1167: Fix haveDelivered wrong implementation.

[GitBox <gi...@apache.org>]

maoling commented on issue #1167: Fix haveDelivered wrong implementation.
URL: https://github.com/apache/zookeeper/pull/1167#issuecomment-563037199
 
 
   @KimRasak 
   - The logic only affects the `queueSendMap` which some queue is empty and others is not empty. In this case, the origin logic enters into `sendNotifications()`, your fix enters into `connectAll()`. Look at the method:`sendNotifications()`, it puts the notification into `sendqueue`.
   , then `WorkerSender.run` poll the notification(`QuorumCnxManager#toSend`), which also connects to other peers(`connectOne(long sid)`)
   
   - > Now the network among (s2, s3, s4) is healthy again, but is it possible that they won't try to connect to each other any more? And maybe the quorum will not be established?
   
       I guess not have that possibility. You can use some tool to reproduce some corner case you image(e.g [blockade](https://blockade.readthedocs.io/en/latest/guide.html))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services