You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Aaron Crickenberger (JIRA)" <ji...@apache.org> on 2008/01/28 15:43:25 UTC

[jira] Created: (CAMEL-310) OgnlExpression causes null Message body/header propagation in Pipeline

OgnlExpression causes null Message body/header propagation in Pipeline
----------------------------------------------------------------------

                 Key: CAMEL-310
                 URL: https://issues.apache.org/activemq/browse/CAMEL-310
             Project: Apache Camel
          Issue Type: Bug
            Reporter: Aaron Crickenberger
         Attachments: camel-ognl.outMessageHandling.patch

OgnlExpression eagerly gets an Exchange's Out Message when it's processing an Exchange.  This causes Pipeline to propagate the non-null Out Message (with null headers/body,) even in cases where the intention is propagate the In Message.  
eg:
{code}
<from uri="direct:start" />
<choice>
<when>
<ognl>request.header.foo == 'bar'</ognl>
<to uri="mock:getsInMessage" />
<to uri="mock:getsOutMessage" />
</when>
</choice>
{code}

The attached patch modifies OgnlExpression to avoid the eager fetch (the map being populated with the value seems unused anyway.)  Long term, maybe Pipeline should look at the Exchange's Pattern to determine which message it needs to propagate?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CAMEL-310) OgnlExpression causes null Message body/header propagation in Pipeline

Posted by "Aaron Crickenberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41173#action_41173 ] 

Aaron Crickenberger commented on CAMEL-310:
-------------------------------------------

This fix applies to the camel-ognl component, but there was no such component in the listbox when I created this issue.

> OgnlExpression causes null Message body/header propagation in Pipeline
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-310
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-310
>             Project: Apache Camel
>          Issue Type: Bug
>            Reporter: Aaron Crickenberger
>         Attachments: camel-ognl.outMessageHandling.patch
>
>
> OgnlExpression eagerly gets an Exchange's Out Message when it's processing an Exchange.  This causes Pipeline to propagate the non-null Out Message (with null headers/body,) even in cases where the intention is propagate the In Message.  
> eg:
> {code}
> <from uri="direct:start" />
> <choice>
> <when>
> <ognl>request.header.foo == 'bar'</ognl>
> <to uri="mock:getsInMessage" />
> <to uri="mock:getsOutMessage" />
> </when>
> </choice>
> {code}
> The attached patch modifies OgnlExpression to avoid the eager fetch (the map being populated with the value seems unused anyway.)  Long term, maybe Pipeline should look at the Exchange's Pattern to determine which message it needs to propagate?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CAMEL-310) OgnlExpression causes null Message body/header propagation in Pipeline

Posted by "Aaron Crickenberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron Crickenberger updated CAMEL-310:
--------------------------------------

    Attachment: camel-ognl.outMessageHandling.patch

> OgnlExpression causes null Message body/header propagation in Pipeline
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-310
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-310
>             Project: Apache Camel
>          Issue Type: Bug
>            Reporter: Aaron Crickenberger
>         Attachments: camel-ognl.outMessageHandling.patch
>
>
> OgnlExpression eagerly gets an Exchange's Out Message when it's processing an Exchange.  This causes Pipeline to propagate the non-null Out Message (with null headers/body,) even in cases where the intention is propagate the In Message.  
> eg:
> {code}
> <from uri="direct:start" />
> <choice>
> <when>
> <ognl>request.header.foo == 'bar'</ognl>
> <to uri="mock:getsInMessage" />
> <to uri="mock:getsOutMessage" />
> </when>
> </choice>
> {code}
> The attached patch modifies OgnlExpression to avoid the eager fetch (the map being populated with the value seems unused anyway.)  Long term, maybe Pipeline should look at the Exchange's Pattern to determine which message it needs to propagate?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (CAMEL-310) OgnlExpression causes null Message body/header propagation in Pipeline

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea resolved CAMEL-310.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0

Patch applied with thanks!  Good work, keep them coming!

> OgnlExpression causes null Message body/header propagation in Pipeline
> ----------------------------------------------------------------------
>
>                 Key: CAMEL-310
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-310
>             Project: Apache Camel
>          Issue Type: Bug
>            Reporter: Aaron Crickenberger
>             Fix For: 1.3.0
>
>         Attachments: camel-ognl.outMessageHandling.patch
>
>
> OgnlExpression eagerly gets an Exchange's Out Message when it's processing an Exchange.  This causes Pipeline to propagate the non-null Out Message (with null headers/body,) even in cases where the intention is propagate the In Message.  
> eg:
> {code}
> <from uri="direct:start" />
> <choice>
> <when>
> <ognl>request.header.foo == 'bar'</ognl>
> <to uri="mock:getsInMessage" />
> <to uri="mock:getsOutMessage" />
> </when>
> </choice>
> {code}
> The attached patch modifies OgnlExpression to avoid the eager fetch (the map being populated with the value seems unused anyway.)  Long term, maybe Pipeline should look at the Exchange's Pattern to determine which message it needs to propagate?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.