[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

[romseygeek <gi...@git.apache.org>]

Github user romseygeek commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/162#discussion_r117773779
  
    --- Diff: lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollector.java ---
    @@ -39,6 +39,14 @@
       private final Sort withinGroupSort;
       private final int maxDocsPerGroup;
     
    +  protected TopGroupsCollector(GroupReducer<T, TopDocsCollector<?>> groupReducer, GroupSelector<T> groupSelector, Collection<SearchGroup<T>> groups, Sort groupSort, Sort withinGroupSort,
    +                            int maxDocsPerGroup, boolean getScores, boolean getMaxScores, boolean fillSortFields) {
    +    super(groupSelector, groups, groupReducer);
    --- End diff --
    
    You can remove a few of these parameters now, I think?  They're for the Reducer, and as such don't need to be passed separately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org