You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2003/09/04 15:18:24 UTC
required changes for APR 1.0
I needed to make the following changes in order to get the perl-framework
running with Apache 2.1, which is now upated for APR 1.0. I went back and
checked 2.0.39 and both the symbols are there, so the changes are good at
least that far back. I guess we need to decide how far back support for
httpd/apr should go...
--Geoff
Re: required changes for APR 1.0
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Cliff Woolley wrote:
> On Thu, 4 Sep 2003, Stas Bekman wrote:
>
>
>>it probably doesn't make any difference if older releases won't work
>>with it.
>
>
> +1. As long as the top-of-tree 1.3-dev, 2.0-dev, and 2.1-dev all build
> and run, that's fine. Older point releases are not an issue.
tested against cvs 1.3, 2.0, and 2.1 - all build and run.
of course, tests are failing on 1.3 and 2.0, but they were before too :)
--Geoff
Re: required changes for APR 1.0
Posted by Cliff Woolley <jw...@virginia.edu>.
On Thu, 4 Sep 2003, Stas Bekman wrote:
> it probably doesn't make any difference if older releases won't work
> with it.
+1. As long as the top-of-tree 1.3-dev, 2.0-dev, and 2.1-dev all build
and run, that's fine. Older point releases are not an issue.
Re: required changes for APR 1.0
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
> I needed to make the following changes in order to get the
> perl-framework running with Apache 2.1, which is now upated for APR
> 1.0. I went back and checked 2.0.39 and both the symbols are there, so
> the changes are good at least that far back. I guess we need to decide
> how far back support for httpd/apr should go...
Since this framework is used only by developers IMHO it should support the
latest 2.0 and 2.1 trees, and may be the very last release in each trunk. it
probably doesn't make any difference if older releases won't work with it.
Please correct me if I'm wrong.
> ------------------------------------------------------------------------
>
> Index: perl-framework/c-modules/input_body_filter/mod_input_body_filter.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-test/perl-framework/c-modules/input_body_filter/mod_input_body_filter.c,v
> retrieving revision 1.10
> diff -u -r1.10 mod_input_body_filter.c
> --- perl-framework/c-modules/input_body_filter/mod_input_body_filter.c 28 Jun 2002 08:40:43 -0000 1.10
> +++ perl-framework/c-modules/input_body_filter/mod_input_body_filter.c 4 Sep 2003 13:14:00 -0000
> @@ -167,7 +167,7 @@
>
> static const command_rec input_body_filter_cmds[] = {
> AP_INIT_FLAG("InputBodyFilter", ap_set_flag_slot,
> - APR_XtOffsetOf(input_body_filter_dcfg_t, enabled),
> + APR_OFFSETOF(input_body_filter_dcfg_t, enabled),
> OR_ALL, "Enable input body filter"),
> { NULL }
> };
> Index: perl-framework/c-modules/test_apr_uri/mod_test_apr_uri.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-test/perl-framework/c-modules/test_apr_uri/mod_test_apr_uri.c,v
> retrieving revision 1.4
> diff -u -r1.4 mod_test_apr_uri.c
> --- perl-framework/c-modules/test_apr_uri/mod_test_apr_uri.c 3 Feb 2003 17:11:01 -0000 1.4
> +++ perl-framework/c-modules/test_apr_uri/mod_test_apr_uri.c 4 Sep 2003 13:14:00 -0000
> @@ -217,7 +217,7 @@
> }
> *strp = 0;
>
> - apr_pool_sub_make(&sub, r->pool, NULL);
> + apr_pool_create_ex(&sub, r->pool, NULL, NULL);
> status = apr_uri_parse(sub, input_uri, &result);
> if (status == APR_SUCCESS) {
> #define CHECK(f) \
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com