You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/01 04:19:20 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

sureshanaparti commented on a change in pull request #4172:
URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448106079



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2068,13 +2068,16 @@ protected StartAnswer execute(StartCommand cmd) {
                         }
                     }
                 } else {
-                    controllerKey = vmMo.getScsiDiskControllerKeyNoException(diskController);
+                    if (VmwareHelper.isReservedScsiDeviceNumber(scsiUnitNumber))

Review comment:
       > Minor one: can you please add braces to this if statement?
   
   updated this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org