[GitHub] [lucene] mogui commented on a change in pull request #679: Monitor Improvements LUCENE-10422

[GitBox <gi...@apache.org>]

mogui commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r806709538



##########
File path: lucene/monitor/src/java/org/apache/lucene/monitor/QueryIndex.java
##########
@@ -87,8 +81,20 @@
   final Map<IndexReader.CacheKey, QueryTermFilter> termFilters = new HashMap<>();
 
   QueryIndex(MonitorConfiguration config, Presearcher presearcher) throws IOException {

Review comment:
       HI @romseygeek, thanks for the reply, ok for everything!
    I'll work on that, regarding the interface implementation split, that I agree it's more clear, How you suggest to let user select the implementattion? Keeping the readonly flag in MonitorConfiguration and instantiating the correct on in Monitor, should be enough?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org