You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2023/03/08 21:32:15 UTC
[GitHub] [trafficserver] cmcfarlen opened a new pull request, #9511: Fix records events deps
cmcfarlen opened a new pull request, #9511:
URL: https://github.com/apache/trafficserver/pull/9511
This PR moves the code depending on iocore/eventsystem into eventsystem to avoid circular dependencies. I'm open to better naming for files and functions or a better method for encapsulating the event system code, but this does remove the circular deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on a diff in pull request #9511: Fix records events deps
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on code in PR #9511:
URL: https://github.com/apache/trafficserver/pull/9511#discussion_r1133814235
##########
include/records/I_RecDefs.h:
##########
@@ -151,6 +151,19 @@ struct RecRawStat {
uint32_t version;
};
+struct RecRawStatBlock;
+
+// This defines the interface to the low level stat block operations
+// The implementation of this was moved out of the records library due to a circular dependency this produced.
+// look for the implmenetation of RecRawStatBlockOps in iocore/eventsystem
Review Comment:
typo? `implementation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #9511: Fix records events deps
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #9511:
URL: https://github.com/apache/trafficserver/pull/9511#discussion_r1145132239
##########
src/traffic_server/traffic_server.cc:
##########
@@ -77,7 +77,7 @@ extern "C" int plock(int);
#include "tscore/I_Layout.h"
#include "I_Machine.h"
#include "records/I_RecordsConfig.h"
-#include "records/I_RecProcess.h"
+#include "RecProcess.h"
Review Comment:
Since ` RecProcess.h` is an header file used by other subsystems, shouldn't it be in the` include/` directory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen merged pull request #9511: Fix records events deps
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #9511:
URL: https://github.com/apache/trafficserver/pull/9511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9511: Fix records events deps
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9511:
URL: https://github.com/apache/trafficserver/pull/9511#discussion_r1145283425
##########
src/traffic_server/traffic_server.cc:
##########
@@ -77,7 +77,7 @@ extern "C" int plock(int);
#include "tscore/I_Layout.h"
#include "I_Machine.h"
#include "records/I_RecordsConfig.h"
-#include "records/I_RecProcess.h"
+#include "RecProcess.h"
Review Comment:
Maybe, but there isn't an include/iocore directory and everything that depends on this already has iocore/eventsystem in their include path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org