[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11166: Fix the issue of consuming segment entering ERROR state due to stream connection errors

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #11166:
URL: https://github.com/apache/pinot/pull/11166#discussion_r1272916639


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -234,7 +234,7 @@ public void deleteSegmentFile() {
   private final ServerMetrics _serverMetrics;
   private final PartitionUpsertMetadataManager _partitionUpsertMetadataManager;
   private final BooleanSupplier _isReadyToConsumeData;
-  private final MutableSegmentImpl _realtimeSegment;
+  private MutableSegmentImpl _realtimeSegment;

Review Comment:
   (MAJOR) I think this can cause NPE when querying the segment if the segment is not set up before state message returns



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org