You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/06/17 05:19:11 UTC
Review Request: Best effort support for open-views.ee getting a string
dataModel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/
-----------------------------------------------------------
Review request for shindig, Henry Saputra and Ryan Baxter.
Description
-------
Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
Also, this patch has been cleaned up to get rid of conflicts on applying.
This addresses bug SHINDIG-1798.
https://issues.apache.org/jira/browse/SHINDIG-1798
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/5345/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8330
-----------------------------------------------------------
Ship it!
Carrying over from the other review :)
- Ryan Baxter
On June 17, 2012, 4:44 a.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 17, 2012, 4:44 a.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Ryan Baxter <rb...@gmail.com>.
> On June 19, 2012, 12:38 a.m., Ryan Baxter wrote:
> > Dan instead of creating a whole new gadget to test with, could you modify the sample gadget which already leverages these APIs?
> > https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
>
> Dan Dumont wrote:
> I just wanted a simple test gadget for this 1 use case. I didn't want to clutter up the photolist example which, IMO, is a demo of a use case rather than a test gadget.
Yeah but finding this test will be hard. People already go to the embedded experiences container for several things:
1.) To see how a container renders embedded experiences
2.) To see how to build an embedded experience gadget
3.) To see how embedded experiences can be placed in an activity stream
4.) To see how to open embedded experiences from a gadget via gadgets.views.openEmbeddedExperience
Your gadget is off in another folder somewhere and people who are new to Shindig and are interested in EE will have a hard time finding it. I think exercising this use case in the existing gadget that already uses gadgets.views.openEmbeddedExperience keeps things more centralized and easier to find.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8373
-----------------------------------------------------------
On June 18, 2012, 7:01 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 7:01 p.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
> On June 19, 2012, 12:38 a.m., Ryan Baxter wrote:
> > Dan instead of creating a whole new gadget to test with, could you modify the sample gadget which already leverages these APIs?
> > https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
I just wanted a simple test gadget for this 1 use case. I didn't want to clutter up the photolist example which, IMO, is a demo of a use case rather than a test gadget.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8373
-----------------------------------------------------------
On June 18, 2012, 7:01 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 7:01 p.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8373
-----------------------------------------------------------
Dan instead of creating a whole new gadget to test with, could you modify the sample gadget which already leverages these APIs?
https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
- Ryan Baxter
On June 18, 2012, 7:01 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 18, 2012, 7:01 p.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8394
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 19, 2012, 2:48 p.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 2:48 p.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351468
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/
-----------------------------------------------------------
(Updated June 19, 2012, 2:48 p.m.)
Review request for shindig, Henry Saputra and Ryan Baxter.
Changes
-------
Added example to the photolist gadget in the ee container.
Description
-------
Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
Also, this patch has been cleaned up to get rid of conflicts on applying.
This addresses bug SHINDIG-1798.
https://issues.apache.org/jira/browse/SHINDIG-1798
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351468
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/5345/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/
-----------------------------------------------------------
(Updated June 18, 2012, 7:01 p.m.)
Review request for shindig, Henry Saputra and Ryan Baxter.
Changes
-------
Henry, thanks for the review. You're right I'm not sure why we weren't using that to begin with in the actions code either.
I've updated the code to use that feature instead and removed the redundant code.
Also included a test gadget.
Description
-------
Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
Also, this patch has been cleaned up to get rid of conflicts on applying.
This addresses bug SHINDIG-1798.
https://issues.apache.org/jira/browse/SHINDIG-1798
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/5345/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/
-----------------------------------------------------------
(Updated June 18, 2012, 5:53 p.m.)
Review request for shindig, Henry Saputra and Ryan Baxter.
Changes
-------
Fix actions call to pass correct param to convertXmlToJson
Description
-------
Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
Also, this patch has been cleaned up to get rid of conflicts on applying.
This addresses bug SHINDIG-1798.
https://issues.apache.org/jira/browse/SHINDIG-1798
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/5345/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8333
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js
<https://reviews.apache.org/r/5345/#comment17966>
I think there is already a util function in the xmlutil feature that does this same parsing in Shindig.
Anything special for this XML to DOM parser compare to the one in the xmlutil feature?
- Henry Saputra
On June 17, 2012, 4:44 a.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 17, 2012, 4:44 a.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/
-----------------------------------------------------------
(Updated June 17, 2012, 4:44 a.m.)
Review request for shindig, Henry Saputra and Ryan Baxter.
Changes
-------
Fix white spaces.
Description
-------
Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
Also, this patch has been cleaned up to get rid of conflicts on applying.
This addresses bug SHINDIG-1798.
https://issues.apache.org/jira/browse/SHINDIG-1798
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
Diff: https://reviews.apache.org/r/5345/diff/
Testing
-------
Thanks,
Dan Dumont
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8305
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js
<https://reviews.apache.org/r/5345/#comment17921>
For the record. I'm aware of the whitespace and will take care of it soon. Been fighting with reviewboard issues today.
- Dan Dumont
On June 17, 2012, 3:19 a.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 17, 2012, 3:19 a.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>
Re: Review Request: Best effort support for open-views.ee getting a string
dataModel
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5345/#review8306
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js
<https://reviews.apache.org/r/5345/#comment17922>
Hmm... there's a checkmark here that says "Open an issue" in this comment dialog... I wonder what it does...
- Dan Dumont
On June 17, 2012, 3:19 a.m., Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5345/
> -----------------------------------------------------------
>
> (Updated June 17, 2012, 3:19 a.m.)
>
>
> Review request for shindig, Henry Saputra and Ryan Baxter.
>
>
> Description
> -------
>
> Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/
>
> Also, this patch has been cleaned up to get rid of conflicts on applying.
>
>
> This addresses bug SHINDIG-1798.
> https://issues.apache.org/jira/browse/SHINDIG-1798
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1349992
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5345/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Dumont
>
>