You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/04/13 05:43:53 UTC
[GitHub] [incubator-sedona] hemenduroy opened a new pull request, #606: Hemendu Roy
hemenduroy opened a new pull request, #606:
URL: https://github.com/apache/incubator-sedona/pull/606
## Is this PR related to a proposed Issue?
[SEDONA-105](https://issues.apache.org/jira/browse/SEDONA-105)
## What changes were proposed in this PR?
Added ST_PointOnSurface
## How was this patch tested?
Added unit tests for Scala, Python and Java. Tested the website using mkdocs.
## Did this PR include necessary documentation updates?
Yes. Added descriptions on the websites and in the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] hemenduroy commented on pull request #606: [SEDONA-105] Add ST_PointOnSurface function
Posted by GitBox <gi...@apache.org>.
hemenduroy commented on PR #606:
URL: https://github.com/apache/incubator-sedona/pull/606#issuecomment-1098550415
@jiayuasu I was not aware Python unit tests had to be run separately. Fixed it and ran the tests locally now. I'm now getting an error in a file that I have not modified. I suspect it may have to do with my environment but I'm not sure. (Scala 2.13.0, Python 3.8.10, Spark 3.2.1)
```
_____________ TestCrsTransformation.test_polygon_distance_join_with_crs_transformation ______________
self = <tests.utils.test_crs_transformation.TestCrsTransformation object at 0x7f726e45d3d0>
def test_polygon_distance_join_with_crs_transformation(self):
query_rdd = PolygonRDD(
self.sc,
input_location_query_polygon, splitter, True,
num_partitions, StorageLevel.MEMORY_ONLY, "epsg:4326", "epsg:3857"
)
window_rdd = CircleRDD(query_rdd, 0.1)
object_rdd = PolygonRDD(
self.sc, input_location_query_polygon, splitter, True, num_partitions, StorageLevel.MEMORY_ONLY,
"epsg:4326", "epsg:3857")
object_rdd.rawJvmSpatialRDD.jsrdd.repartition(4)
object_rdd.spatialPartitioning(GridType.KDBTREE)
object_rdd.buildIndex(IndexType.RTREE, True)
window_rdd.spatialPartitioning(object_rdd.getPartitioner())
results = JoinQuery.DistanceJoinQuery(object_rdd, window_rdd, True, False).collect()
assert 5467 == results.__len__()
for data in results:
for polygon_data in data[1]:
> assert Circle(data[0].geom, 0.1).covers(polygon_data.geom)
E assert False
E + where False = <bound method Circle.covers of <sedona.core.geom.circle.Circle object at 0x7f726dd79910>>(<shapely.geometry.polygon.Polygon object at 0x7f726e1a59d0>)
E + where <bound method Circle.covers of <sedona.core.geom.circle.Circle object at 0x7f726dd79910>> = <sedona.core.geom.circle.Circle object at 0x7f726dd79910>.covers
E + where <sedona.core.geom.circle.Circle object at 0x7f726dd79910> = Circle(<shapely.geometry.polygon.Polygon object at 0x7f726e1a57f0>, 0.1)
E + where <shapely.geometry.polygon.Polygon object at 0x7f726e1a57f0> = Geometry: Polygon userData: .geom
E + and <shapely.geometry.polygon.Polygon object at 0x7f726e1a59d0> = Geometry: Polygon userData: .geom
tests/utils/test_crs_transformation.py:185: AssertionError
```
```
====================================== short test summary info ======================================
FAILED tests/utils/test_crs_transformation.py::TestCrsTransformation::test_polygon_distance_join_with_crs_transformation
================ 1 failed, 416 passed, 2 skipped, 197 warnings in 461.38s (0:07:41) =================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu merged pull request #606: [SEDONA-105] Add ST_PointOnSurface function
Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #606:
URL: https://github.com/apache/incubator-sedona/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] hemenduroy commented on pull request #606: [SEDONA-105] Add ST_PointOnSurface function
Posted by GitBox <gi...@apache.org>.
hemenduroy commented on PR #606:
URL: https://github.com/apache/incubator-sedona/pull/606#issuecomment-1098389566
Fixed merge conflicts and unit test issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on pull request #606: [SEDONA-105] Add ST_PointOnSurface function
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #606:
URL: https://github.com/apache/incubator-sedona/pull/606#issuecomment-1098434327
@hemenduroy Please fix the python test case. The error is
```
AssertionError: assert 'POINT (0 5)' == 'POINT(0 5)'
E - POINT(0 5)
E + POINT (0 5)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org