You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/13 22:07:14 UTC

[GitHub] [incubator-druid] suneet-s opened a new pull request #9035: Fix equalsAndHashCode in ClientCompactQueryTuningConfig

suneet-s opened a new pull request #9035: Fix equalsAndHashCode in ClientCompactQueryTuningConfig
URL: https://github.com/apache/incubator-druid/pull/9035
 
 
   Fixes #8866.
   
   ### Description
   
   This change introduces a dependency to EqualsVerifier for the test scope.
   The dependency is licensed under Apache 2. The library makes it trivial
   to add equals and hashCode checks to prevent bugs like this from happening
   in the future
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths.
   
   <hr>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org