You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2016/04/18 15:11:25 UTC

[jira] [Comment Edited] (TINKERPOP-946) Traversal respecting Thread.interrupt()

    [ https://issues.apache.org/jira/browse/TINKERPOP-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245622#comment-15245622 ] 

stephen mallette edited comment on TINKERPOP-946 at 4/18/16 1:11 PM:
---------------------------------------------------------------------

Did some work here to implement this and ran gremlin-benchmark ( https://gist.github.com/spmallette/ed21267f2e7e17bb3fbd5a8d1a568d2b ) :

{code}
WITHOUT INTERRUPT

Benchmark                                                                                         Mode  Cnt     Score     Error  Units
GraphTraversalBenchmark.g_E_hasLabelXwrittenByX_whereXinV_inEXsungByX_count_isX0XX_subgraphXsgX  thrpt   20   433.002 ±  22.085  ops/s
GraphTraversalBenchmark.g_V_label_groupCount                                                     thrpt   20  7209.703 ± 130.932  ops/s
GraphTraversalBenchmark.g_V_localXout_out_valuesXnameX_foldX                                     thrpt   20    13.210 ±   0.524  ops/s
GraphTraversalBenchmark.g_V_match_selectXbX_valuesXnameX                                         thrpt   20  3186.930 ± 388.578  ops/s
GraphTraversalBenchmark.g_V_outE_inV_outE_inV_outE_inV                                           thrpt   20     0.885 ±   0.025  ops/s
GraphTraversalBenchmark.g_V_out_localXout_out_valuesXnameX_foldX                                 thrpt   20     0.233 ±   0.053  ops/s
GraphTraversalBenchmark.g_V_out_mapXout_out_valuesXnameX_toListX                                 thrpt   20     0.423 ±   0.009  ops/s
GraphTraversalBenchmark.g_V_out_out_out                                                          thrpt   20     0.903 ±   0.015  ops/s
GraphTraversalBenchmark.g_V_out_out_out_path                                                     thrpt   20     0.058 ±   0.013  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX2X                                                 thrpt   20    23.742 ±   0.717  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX3X                                                 thrpt   20     2.345 ±   0.099  ops/s

WITH INTERRUPT

Benchmark                                                                                         Mode  Cnt     Score     Error  Units
GraphTraversalBenchmark.g_E_hasLabelXwrittenByX_whereXinV_inEXsungByX_count_isX0XX_subgraphXsgX  thrpt   20   424.980 ±  25.509  ops/s
GraphTraversalBenchmark.g_V_label_groupCount                                                     thrpt   20  6920.125 ± 288.286  ops/s
GraphTraversalBenchmark.g_V_localXout_out_valuesXnameX_foldX                                     thrpt   20    13.147 ±   0.589  ops/s
GraphTraversalBenchmark.g_V_match_selectXbX_valuesXnameX                                         thrpt   20  3663.093 ± 242.539  ops/s
GraphTraversalBenchmark.g_V_outE_inV_outE_inV_outE_inV                                           thrpt   20     0.914 ±   0.034  ops/s
GraphTraversalBenchmark.g_V_out_localXout_out_valuesXnameX_foldX                                 thrpt   20     0.317 ±   0.008  ops/s
GraphTraversalBenchmark.g_V_out_mapXout_out_valuesXnameX_toListX                                 thrpt   20     0.433 ±   0.012  ops/s
GraphTraversalBenchmark.g_V_out_out_out                                                          thrpt   20     0.912 ±   0.024  ops/s
GraphTraversalBenchmark.g_V_out_out_out_path                                                     thrpt   20     0.045 ±   0.009  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX2X                                                 thrpt   20    22.773 ±   0.436  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX3X                                                 thrpt   20     2.155 ±   0.131  ops/s

WITHOUT INTERRUPT

Benchmark                                     Mode  Cnt         Score         Error  Units
GraphMutateBenchmark.testAddE                thrpt   20     40856.030 ±    4533.506  ops/s
GraphMutateBenchmark.testAddEdge             thrpt   20   3264592.648 ±  258747.094  ops/s
GraphMutateBenchmark.testAddV                thrpt   20    553033.856 ±   22083.826  ops/s
GraphMutateBenchmark.testAddVertex           thrpt   20   5788322.626 ±  405728.238  ops/s
GraphMutateBenchmark.testEdgeProperty        thrpt   20  10828146.027 ± 1575892.641  ops/s
GraphMutateBenchmark.testEdgePropertyStep    thrpt   20    184517.929 ±    7717.985  ops/s
GraphMutateBenchmark.testVertexProperty      thrpt   20   4664901.713 ±  355620.823  ops/s
GraphMutateBenchmark.testVertexPropertyStep  thrpt   20    164545.617 ±   16218.479  ops/s

WITH INTERRUPT

Benchmark                                     Mode  Cnt         Score         Error  Units
GraphMutateBenchmark.testAddE                thrpt   20     40366.064 ±    5311.549  ops/s
GraphMutateBenchmark.testAddEdge             thrpt   20   3394429.025 ±  215705.312  ops/s
GraphMutateBenchmark.testAddV                thrpt   20    535506.229 ±   16138.350  ops/s
GraphMutateBenchmark.testAddVertex           thrpt   20   5685259.448 ±  492161.001  ops/s
GraphMutateBenchmark.testEdgeProperty        thrpt   20  11337725.761 ± 1600906.128  ops/s
GraphMutateBenchmark.testEdgePropertyStep    thrpt   20    180209.108 ±    8663.875  ops/s
GraphMutateBenchmark.testVertexProperty      thrpt   20   4628182.249 ±  393292.238  ops/s
GraphMutateBenchmark.testVertexPropertyStep  thrpt   20    169016.050 ±    7639.421  ops/s
{code}


was (Author: spmallette):
Did some work here to implement this and ran gremlin-benchmark:

{code}
WITHOUT INTERRUPT

Benchmark                                                                                         Mode  Cnt     Score     Error  Units
GraphTraversalBenchmark.g_E_hasLabelXwrittenByX_whereXinV_inEXsungByX_count_isX0XX_subgraphXsgX  thrpt   20   433.002 ±  22.085  ops/s
GraphTraversalBenchmark.g_V_label_groupCount                                                     thrpt   20  7209.703 ± 130.932  ops/s
GraphTraversalBenchmark.g_V_localXout_out_valuesXnameX_foldX                                     thrpt   20    13.210 ±   0.524  ops/s
GraphTraversalBenchmark.g_V_match_selectXbX_valuesXnameX                                         thrpt   20  3186.930 ± 388.578  ops/s
GraphTraversalBenchmark.g_V_outE_inV_outE_inV_outE_inV                                           thrpt   20     0.885 ±   0.025  ops/s
GraphTraversalBenchmark.g_V_out_localXout_out_valuesXnameX_foldX                                 thrpt   20     0.233 ±   0.053  ops/s
GraphTraversalBenchmark.g_V_out_mapXout_out_valuesXnameX_toListX                                 thrpt   20     0.423 ±   0.009  ops/s
GraphTraversalBenchmark.g_V_out_out_out                                                          thrpt   20     0.903 ±   0.015  ops/s
GraphTraversalBenchmark.g_V_out_out_out_path                                                     thrpt   20     0.058 ±   0.013  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX2X                                                 thrpt   20    23.742 ±   0.717  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX3X                                                 thrpt   20     2.345 ±   0.099  ops/s

WITH INTERRUPT

Benchmark                                                                                         Mode  Cnt     Score     Error  Units
GraphTraversalBenchmark.g_E_hasLabelXwrittenByX_whereXinV_inEXsungByX_count_isX0XX_subgraphXsgX  thrpt   20   424.980 ±  25.509  ops/s
GraphTraversalBenchmark.g_V_label_groupCount                                                     thrpt   20  6920.125 ± 288.286  ops/s
GraphTraversalBenchmark.g_V_localXout_out_valuesXnameX_foldX                                     thrpt   20    13.147 ±   0.589  ops/s
GraphTraversalBenchmark.g_V_match_selectXbX_valuesXnameX                                         thrpt   20  3663.093 ± 242.539  ops/s
GraphTraversalBenchmark.g_V_outE_inV_outE_inV_outE_inV                                           thrpt   20     0.914 ±   0.034  ops/s
GraphTraversalBenchmark.g_V_out_localXout_out_valuesXnameX_foldX                                 thrpt   20     0.317 ±   0.008  ops/s
GraphTraversalBenchmark.g_V_out_mapXout_out_valuesXnameX_toListX                                 thrpt   20     0.433 ±   0.012  ops/s
GraphTraversalBenchmark.g_V_out_out_out                                                          thrpt   20     0.912 ±   0.024  ops/s
GraphTraversalBenchmark.g_V_out_out_out_path                                                     thrpt   20     0.045 ±   0.009  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX2X                                                 thrpt   20    22.773 ±   0.436  ops/s
GraphTraversalBenchmark.g_V_repeatXoutX_timesX3X                                                 thrpt   20     2.155 ±   0.131  ops/s

WITHOUT INTERRUPT

Benchmark                                     Mode  Cnt         Score         Error  Units
GraphMutateBenchmark.testAddE                thrpt   20     40856.030 ±    4533.506  ops/s
GraphMutateBenchmark.testAddEdge             thrpt   20   3264592.648 ±  258747.094  ops/s
GraphMutateBenchmark.testAddV                thrpt   20    553033.856 ±   22083.826  ops/s
GraphMutateBenchmark.testAddVertex           thrpt   20   5788322.626 ±  405728.238  ops/s
GraphMutateBenchmark.testEdgeProperty        thrpt   20  10828146.027 ± 1575892.641  ops/s
GraphMutateBenchmark.testEdgePropertyStep    thrpt   20    184517.929 ±    7717.985  ops/s
GraphMutateBenchmark.testVertexProperty      thrpt   20   4664901.713 ±  355620.823  ops/s
GraphMutateBenchmark.testVertexPropertyStep  thrpt   20    164545.617 ±   16218.479  ops/s

WITH INTERRUPT

Benchmark                                     Mode  Cnt         Score         Error  Units
GraphMutateBenchmark.testAddE                thrpt   20     40366.064 ±    5311.549  ops/s
GraphMutateBenchmark.testAddEdge             thrpt   20   3394429.025 ±  215705.312  ops/s
GraphMutateBenchmark.testAddV                thrpt   20    535506.229 ±   16138.350  ops/s
GraphMutateBenchmark.testAddVertex           thrpt   20   5685259.448 ±  492161.001  ops/s
GraphMutateBenchmark.testEdgeProperty        thrpt   20  11337725.761 ± 1600906.128  ops/s
GraphMutateBenchmark.testEdgePropertyStep    thrpt   20    180209.108 ±    8663.875  ops/s
GraphMutateBenchmark.testVertexProperty      thrpt   20   4628182.249 ±  393292.238  ops/s
GraphMutateBenchmark.testVertexPropertyStep  thrpt   20    169016.050 ±    7639.421  ops/s
{code}

> Traversal respecting Thread.interrupt()
> ---------------------------------------
>
>                 Key: TINKERPOP-946
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-946
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.2.1
>
>
> This issue was discussed to some degree here:
> https://pony-poc.apache.org/thread.html/e6477fc9c58d37a5bdcb5938a0eaa285456ad15aa39e16446290e2ff@1444993523@%3Cdev.tinkerpop.apache.org%3E
> There's a good half-way solution in all this that balances performance with the desired capability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)