svn commit: r239363 - /httpd/mod_smtpd/trunk/smtp_core.c

[so...@apache.org]

Author: soc-rian
Date: Mon Aug 22 23:18:57 2005
New Revision: 239363

URL: http://svn.apache.org/viewcvs?rev=239363&view=rev
Log:
fixed up some dirty comments

Modified:
    httpd/mod_smtpd/trunk/smtp_core.c

Modified: httpd/mod_smtpd/trunk/smtp_core.c
URL: http://svn.apache.org/viewcvs/httpd/mod_smtpd/trunk/smtp_core.c?rev=239363&r1=239362&r2=239363&view=diff
==============================================================================
--- httpd/mod_smtpd/trunk/smtp_core.c (original)
+++ httpd/mod_smtpd/trunk/smtp_core.c Mon Aug 22 23:18:57 2005
@@ -123,7 +123,9 @@
 /* public methods */
 /* functions other modules can use */
 
-/* should be called at smtpd_hook_connect */
+/* should be called at smtpd_hook_connect
+ * at least by convention
+ */
 SMTPD_DECLARE_NONSTD(void)
 smtpd_register_extension(smtpd_conn_rec *scr, const char *line)
 {
@@ -298,7 +300,9 @@
   scr->bb_in = apr_brigade_create(scr->p, scr->c->bucket_alloc);
   scr->bb_out = apr_brigade_create(scr->p, scr->c->bucket_alloc);
 
-  //  r->request_config  = ap_create_request_config(r->pool);
+  /* REVIEW: does scr need a request_config?
+   * r->request_config  = ap_create_request_config(r->pool);
+   */
   
   apr_socket_t *csd =
     ((core_net_rec *)conn->input_filters->ctx)->client_socket;
@@ -330,7 +334,10 @@
   }
 
   scr = smtpd_create_conn_rec(c);
-  //  ap_update_child_status(scr->c->sbh, SERVER_BUSY_KEEPALIVE, r);
+  /* REVIEW: is the status only for mod_status to know?
+   * shoudl we support stati ? 
+   * ap_update_child_status(scr->c->sbh, SERVER_BUSY_KEEPALIVE, r);
+   */
 
   smtpd_process_connection_internal(scr);